From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 2a7f01aa38: Fix initialization of module functions
Date: Thu, 10 Nov 2022 13:32:47 -0500 [thread overview]
Message-ID: <jwvr0yall2q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <838rkir83o.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2022 20:13:15 +0200")
>> >> > allocate_module_function (void)
>> >> > {
>> >> > return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function,
>> >> > - interactive_form, PVEC_MODULE_FUNCTION);
>> >> > + command_modes, PVEC_MODULE_FUNCTION);
>> >> > }
>> >> >
>> >> > #define XSET_MODULE_FUNCTION(var, ptr) \
>> >>
>> >> Usually we accompany that with a comment in the struct stating "this
>> >> is the last GC-tracked field" or something like that.
>> >
>> > There's already such a comment, a few lines above.
>>
>> The comment doesn't say which one is the last tracked field.
>
> ??? That's basic C, or what am I missing?
The commit 2a7f01aa38 fixes a bug introduced by commit 58e0c8ee86e2
which did (among other things:)
@@ -548,7 +548,7 @@
{
union vectorlike_header header;
/* Fields traced by GC; these must come first. */
- Lisp_Object documentation, interactive_form;
+ Lisp_Object documentation, interactive_form, command_modes;
/* Fields ignored by GC. */
so clearly the comment was not sufficiently clear for Lars to notice
that adding a field after `interactive_form` would introduce a bug.
Stefan
prev parent reply other threads:[~2022-11-10 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166807775643.29181.14745596143667535171@vcs2.savannah.gnu.org>
[not found] ` <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org>
2022-11-10 14:06 ` master 2a7f01aa38: Fix initialization of module functions Stefan Monnier
2022-11-10 15:23 ` Eli Zaretskii
2022-11-10 17:44 ` Stefan Monnier
2022-11-10 18:13 ` Eli Zaretskii
2022-11-10 18:32 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr0yall2q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.