From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2a7f01aa38: Fix initialization of module functions Date: Thu, 10 Nov 2022 13:32:47 -0500 Message-ID: References: <166807775643.29181.14745596143667535171@vcs2.savannah.gnu.org> <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org> <83r0yarfxz.fsf@gnu.org> <838rkir83o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21936"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 19:33:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otCMz-0005Pd-Og for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 19:33:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otCMe-0004rQ-4i; Thu, 10 Nov 2022 13:33:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otCMW-0004oF-40 for emacs-devel@gnu.org; Thu, 10 Nov 2022 13:33:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otCMI-0002Wg-Sw; Thu, 10 Nov 2022 13:33:15 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3E2334402E0; Thu, 10 Nov 2022 13:32:50 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BA2F9440758; Thu, 10 Nov 2022 13:32:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668105168; bh=XTQfbAPdeLq7VUVOqXVWmYzJnNQ4F2IPMUmlS1pj1qs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WuoiWinCJ6drREiZKY++6M9w7HINBi85y7CU0sXOLcfcSA3iecZwZbyB3uGQNiIQ3 cKFwqGAFyuXEWLlPJg76s5Mz6HSXsYUh+6VF7IRTkY0CGFdzXVndCGXJXt6sGvfT5X 53NHVUbiVEkE14hIcVOdK3EG9+/EOQ7ogctPT+Mj+G7z/1MqMIJXNPoTwTIPZ3aZbk eKiewiDdm4Rn+Uw3kpCbbxWJ4RaQv24coRkGbFCfizCPC+R7YyWV6fk7rLhI3uhRe1 YGidrMSXBYGqpVCB6xbfx0Hqaj8q0zoX9JAEY9nQ/gUocmrsEM8dtkKq1nsFhH2SiZ tuWZALGQzaIsQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A8C6D120A09; Thu, 10 Nov 2022 13:32:48 -0500 (EST) In-Reply-To: <838rkir83o.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2022 20:13:15 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299518 Archived-At: >> >> > allocate_module_function (void) >> >> > { >> >> > return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function, >> >> > - interactive_form, PVEC_MODULE_FUNCTION); >> >> > + command_modes, PVEC_MODULE_FUNCTION); >> >> > } >> >> > >> >> > #define XSET_MODULE_FUNCTION(var, ptr) \ >> >> >> >> Usually we accompany that with a comment in the struct stating "this >> >> is the last GC-tracked field" or something like that. >> > >> > There's already such a comment, a few lines above. >> >> The comment doesn't say which one is the last tracked field. > > ??? That's basic C, or what am I missing? The commit 2a7f01aa38 fixes a bug introduced by commit 58e0c8ee86e2 which did (among other things:) @@ -548,7 +548,7 @@ { union vectorlike_header header; /* Fields traced by GC; these must come first. */ - Lisp_Object documentation, interactive_form; + Lisp_Object documentation, interactive_form, command_modes; /* Fields ignored by GC. */ so clearly the comment was not sufficiently clear for Lars to notice that adding a field after `interactive_form` would introduce a bug. Stefan