From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: using glyphs by default in perl-mode
Date: Mon, 03 Jun 2013 03:04:41 -0400 [thread overview]
Message-ID: <jwvmwr7he9q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8761xw54rv.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 02 Jun 2013 22:04:04 -0400")
Please use prog-mode.el rather than prog.el.
> +(defconst perl--prettify-symbols-alist-basic
> + '(("->" . ?→)
> + ("=>" . ?⇒)
> + ("::" . ?∷)))
I don't think "basic" and "extended" make much sense currently, so the
basic user setting should be a boolean. Major modes should simply
provide *the* alist that makes sense for them.
> +(defconst perl--prettify-symbols-alist-extended
> + `(,@perl--prettify-symbols-alist-basic
> + ("andalso" . ?∧) ("orelse" . ?∨) ("as" . ?≡)("not" . ?¬)
> + ("div" . ?÷) ("*" . ?×) ("o" . ?○)
> + ("<-" . ?←) ("<>" . ?≠) (">=" . ?≥) ("<=" . ?≤) ("..." . ?⋯)))
E.g. this makes very little sense for Perl, since these mapping all come
from sml-mode.el ;-)
> +;; used to add font-lock keywords dynamically
> +(defvar perl-augmented-font-lock-keywords)
> +(defvar perl-augmented-font-lock-keywords-1)
> +(defvar perl-augmented-font-lock-keywords-2)
This smells internal, so please use "--" in their name.
> + (set (make-local-variable 'prog-prettify-symbols-alist) nil)
Just make the default value be nil instead.
> +(defcustom prog-prettify-symbols nil
> + "Which symbols should be prettified.
> +When set to `basic' or `extended' or `all', the actual choices
> +are made by the mode that derives from `prog-mode'."
> + :type '(choice
> + (const :tag "No thanks" nil)
> + (const :tag "Basic list" basic)
> + (const :tag "Extended list: basic plus much more" extended)
> + (const :tag "Everything: because you can!" all)
> + (alist :tag "Define your own list" :key-type string :value-type character))
> + :group 'languages)
Make it into a boolean.
Other than that, looks good, please install.
Stefan
next prev parent reply other threads:[~2013-06-03 7:04 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 0:50 using glyphs by default in perl-mode Dan Nicolaescu
2013-05-05 4:37 ` Stefan Monnier
2013-05-05 7:34 ` James Cloos
2013-05-06 1:09 ` Stefan Monnier
2013-05-06 4:26 ` Dan Nicolaescu
2013-05-06 15:09 ` Stefan Monnier
2013-05-07 16:32 ` Dan Nicolaescu
2013-05-07 21:20 ` Stefan Monnier
2013-05-08 3:22 ` Dan Nicolaescu
2013-05-08 4:02 ` Stefan Monnier
2013-05-09 16:31 ` Dan Nicolaescu
2013-05-09 16:39 ` Eli Zaretskii
2013-05-09 17:22 ` Stefan Monnier
2013-05-09 18:39 ` Dan Nicolaescu
2013-05-09 18:58 ` Andreas Röhler
2013-05-09 19:31 ` James Cloos
2013-05-17 13:01 ` Ted Zlatanov
2013-05-17 15:48 ` Stefan Monnier
2013-05-19 2:50 ` Ted Zlatanov
2013-05-30 0:01 ` Dan Nicolaescu
2013-05-30 14:47 ` Ted Zlatanov
2013-05-30 17:18 ` Stefan Monnier
2013-05-30 20:32 ` Ted Zlatanov
2013-06-01 6:29 ` Dan Nicolaescu
2013-06-01 13:46 ` Ted Zlatanov
2013-06-01 14:47 ` Stefan Monnier
2013-06-02 12:35 ` Ted Zlatanov
2013-06-02 15:52 ` Stefan Monnier
2013-06-03 2:02 ` Ted Zlatanov
2013-06-03 2:04 ` Ted Zlatanov
2013-06-03 7:04 ` Stefan Monnier [this message]
2013-06-04 1:52 ` Ted Zlatanov
2013-06-04 14:28 ` Davis Herring
2013-06-04 17:20 ` Stefan Monnier
2013-06-04 20:06 ` Ted Zlatanov
2013-06-05 1:27 ` Stefan Monnier
2013-06-05 14:45 ` Ted Zlatanov
2013-06-05 16:13 ` Stefan Monnier
2013-06-05 17:28 ` Ted Zlatanov
2013-06-05 17:42 ` joakim
2013-06-05 17:58 ` Ted Zlatanov
2013-06-05 17:50 ` Ted Zlatanov
2013-06-05 18:52 ` Stefan Monnier
2013-06-05 19:36 ` Ted Zlatanov
2013-06-05 20:13 ` joakim
2013-06-05 16:43 ` Glenn Morris
2013-06-05 17:52 ` Ted Zlatanov
2013-06-05 18:07 ` Glenn Morris
2013-06-05 18:33 ` Ted Zlatanov
2013-06-05 18:55 ` Stefan Monnier
2013-06-05 19:34 ` Ted Zlatanov
2013-06-05 20:19 ` Stefan Monnier
2013-06-07 7:36 ` Eli Zaretskii
2013-06-07 7:45 ` Jambunathan K
2013-06-07 7:45 ` bug#13189: " Jambunathan K
2013-06-07 13:05 ` Ted Zlatanov
2013-06-07 16:07 ` Stefan Monnier
2013-06-07 16:07 ` Stefan Monnier
2013-06-07 16:44 ` Glenn Morris
2013-06-07 18:03 ` Ted Zlatanov
2013-06-07 19:14 ` Jambunathan K
2013-06-07 20:04 ` Glenn Morris
2013-06-07 19:15 ` Stefan Monnier
2013-06-07 12:48 ` Ted Zlatanov
2013-06-07 14:52 ` Eli Zaretskii
2013-06-07 15:39 ` Ted Zlatanov
2013-06-07 12:53 ` Kenichi Handa
2013-06-07 14:16 ` compose-region docstring update (was: using glyphs by default in perl-mode) Ted Zlatanov
2013-06-09 12:45 ` Kenichi Handa
2013-05-09 18:30 ` using glyphs by default in perl-mode Dan Nicolaescu
2013-05-10 0:23 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwr7he9q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.