From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: using glyphs by default in perl-mode Date: Mon, 03 Jun 2013 03:04:41 -0400 Message-ID: References: <83li7ocdkb.fsf@gnu.org> <87d2sp92vb.fsf@lifelogs.com> <87bo877kf7.fsf@lifelogs.com> <87obbs7cew.fsf@lifelogs.com> <87ip1y54fx.fsf@lifelogs.com> <87ehck6670.fsf@lifelogs.com> <87a9n854tx.fsf@lifelogs.com> <8761xw54rv.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1370243101 20041 80.91.229.3 (3 Jun 2013 07:05:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Jun 2013 07:05:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 03 09:05:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UjOp7-0003Fh-6Z for ged-emacs-devel@m.gmane.org; Mon, 03 Jun 2013 09:04:57 +0200 Original-Received: from localhost ([::1]:34406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjOp6-0002aP-EQ for ged-emacs-devel@m.gmane.org; Mon, 03 Jun 2013 03:04:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjOox-0002Zz-LA for emacs-devel@gnu.org; Mon, 03 Jun 2013 03:04:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjOos-0002SP-S5 for emacs-devel@gnu.org; Mon, 03 Jun 2013 03:04:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjOos-0002SH-Np for emacs-devel@gnu.org; Mon, 03 Jun 2013 03:04:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYtM/2dsb2JhbABEhke4Rxdzgh8BBSMELzMLGgIYAQ0CAhQYDYhIrl+SToEjjD6CFoETA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFpYtM/2dsb2JhbABEhke4Rxdzgh8BBSMELzMLGgIYAQ0CAhQYDYhIrl+SToEjjD6CFoETA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="15470739" Original-Received: from 69-165-139-76.dsl.teksavvy.com (HELO ceviche.home) ([69.165.139.76]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jun 2013 03:04:36 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 6EC4E660D7; Mon, 3 Jun 2013 03:04:41 -0400 (EDT) In-Reply-To: <8761xw54rv.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 02 Jun 2013 22:04:04 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160026 Archived-At: Please use prog-mode.el rather than prog.el. > +(defconst perl--prettify-symbols-alist-basic > + '(("->" . ?=E2=86=92) > + ("=3D>" . ?=E2=87=92) > + ("::" . ?=E2=88=B7))) I don't think "basic" and "extended" make much sense currently, so the basic user setting should be a boolean. Major modes should simply provide *the* alist that makes sense for them. > +(defconst perl--prettify-symbols-alist-extended > + `(,@perl--prettify-symbols-alist-basic > + ("andalso" . ?=E2=88=A7) ("orelse" . ?=E2=88=A8) ("as" . ?=E2=89=A1= )("not" . ?=C2=AC) > + ("div" . ?=C3=B7) ("*" . ?=C3=97) ("o" . ?=E2=97=8B) > + ("<-" . ?=E2=86=90) ("<>" . ?=E2=89=A0) (">=3D" . ?=E2=89=A5) ("<= =3D" . ?=E2=89=A4) ("..." . ?=E2=8B=AF))) E.g. this makes very little sense for Perl, since these mapping all come from sml-mode.el ;-) > +;; used to add font-lock keywords dynamically > +(defvar perl-augmented-font-lock-keywords) > +(defvar perl-augmented-font-lock-keywords-1) > +(defvar perl-augmented-font-lock-keywords-2) This smells internal, so please use "--" in their name. > + (set (make-local-variable 'prog-prettify-symbols-alist) nil) Just make the default value be nil instead. > +(defcustom prog-prettify-symbols nil > + "Which symbols should be prettified. > +When set to `basic' or `extended' or `all', the actual choices > +are made by the mode that derives from `prog-mode'." > + :type '(choice > + (const :tag "No thanks" nil) > + (const :tag "Basic list" basic) > + (const :tag "Extended list: basic plus much more" extended) > + (const :tag "Everything: because you can!" all) > + (alist :tag "Define your own list" :key-type string :value-typ= e character)) > + :group 'languages) Make it into a boolean. Other than that, looks good, please install. Stefan