all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: martin rudalics <rudalics@gmx.at>, 59605@debbugs.gnu.org
Subject: bug#59605: 29.0.50; gdb no more creates Gud menu entry for source file window
Date: Mon, 28 Nov 2022 12:55:37 -0500	[thread overview]
Message-ID: <jwvlenvt16m.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <837czhsl71.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Nov 2022 19:02:42 +0200")

>> With emacs -Q visit an arbitrary Emacs C source file and do your
>> equivalent of M-: (gdb "gdb -i=mi emacs").  Now selecting the window
>> showing the source file buffer no more shows a Gud menu entry.  This has
>> the consequence that mouse clicking in a fringe no more sets/unsets a
>> breakpoint in that buffer.
>> 
>> The commit responsible for that behavior is
>> 
>> commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2
>> Author: Lars Ingebrigtsen <larsi@gnus.org>
>> Date:   Thu Sep 1 13:39:14 2022 +0200
>> 
>>      Make easy-mmode-defmap obsolete and adjust only caller
>> 
>>      * lisp/emacs-lisp/easy-mmode.el (easy-mmode-defmap): Make obsolete.
>>      * lisp/progmodes/gud.el (gud-menu-map): Use easy-menu-define.
>
> Stefan, can you help here?  It looks like gud-minor-mode is not a proper
> minor mode,

Indeed, we should fix that.

> so the new code isn't working because gud-minor-mode-map is not
> in effect or something?

The immediate problem in the patch is that it removed

    (setf (alist-get 'gud-minor-mode minor-mode-map-alist)
          gud-minor-mode-map)

without replacing it with anything else.
Re-adding those 2 lines seems to bring back the previous behavior.


        Stefan






  reply	other threads:[~2022-11-28 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26 10:28 bug#59605: 29.0.50; gdb no more creates Gud menu entry for source file window martin rudalics
2022-11-26 17:02 ` Eli Zaretskii
2022-11-28 17:55   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-28 19:21     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlenvt16m.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59605@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.