From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59605: 29.0.50; gdb no more creates Gud menu entry for source file window Date: Mon, 28 Nov 2022 12:55:37 -0500 Message-ID: References: <53e5eea9-0550-af08-bc73-6918aa3f912e@gmx.at> <837czhsl71.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32354"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , 59605@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 18:56:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oziMa-00087X-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 18:56:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oziMO-00042p-Bl; Mon, 28 Nov 2022 12:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oziMN-00042N-2K for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oziMM-0002Ji-Pl for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oziMM-0000dL-M4 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 12:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59605 X-GNU-PR-Package: emacs Original-Received: via spool by 59605-submit@debbugs.gnu.org id=B59605.16696581472426 (code B ref 59605); Mon, 28 Nov 2022 17:56:02 +0000 Original-Received: (at 59605) by debbugs.gnu.org; 28 Nov 2022 17:55:47 +0000 Original-Received: from localhost ([127.0.0.1]:50033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oziM7-0000d4-C5 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 12:55:47 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oziM5-0000cy-4f for 59605@debbugs.gnu.org; Mon, 28 Nov 2022 12:55:46 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B0CA51000F8; Mon, 28 Nov 2022 12:55:39 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 11AA01000DC; Mon, 28 Nov 2022 12:55:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669658138; bh=kfAIPBhUM4lLgLja4Wu8gpAillMWjQZzjeSkOA7szu0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nSgu/Jx4Qox3y98xVmmnsXO0Frefo4ttyvNdbMP6BIosFjihOvQ0DhGx29Xv/IAUO JRmCqVtDHAZsxqrkH7NxuLCstXNRhLEs6Bhmj9Dq5tLOb3vGnpcmVSw2V3apTgyt9o FSN4DsL/yBnLDvSUTHj/LZ0L7z8pzKFjqqCkSPtWeO3BSzkSsFTLhaVFooF/bvR2LA rQTMIpNS0f5Y+6GRyD6MBokqT9mbfHeQg9HFy3IpduOw9uzh9HZbhrlGOB4cb0S1H3 IEzP66BdjqrdFbDZP+Rxd5cpzbujvu7lPZUylaRGs+jSzOnJtyQCXPiMhMJOdFEYLh 1H4Pn/odQHnmQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C9D48120776; Mon, 28 Nov 2022 12:55:37 -0500 (EST) In-Reply-To: <837czhsl71.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Nov 2022 19:02:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249334 Archived-At: >> With emacs -Q visit an arbitrary Emacs C source file and do your >> equivalent of M-: (gdb "gdb -i=mi emacs"). Now selecting the window >> showing the source file buffer no more shows a Gud menu entry. This has >> the consequence that mouse clicking in a fringe no more sets/unsets a >> breakpoint in that buffer. >> >> The commit responsible for that behavior is >> >> commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2 >> Author: Lars Ingebrigtsen >> Date: Thu Sep 1 13:39:14 2022 +0200 >> >> Make easy-mmode-defmap obsolete and adjust only caller >> >> * lisp/emacs-lisp/easy-mmode.el (easy-mmode-defmap): Make obsolete. >> * lisp/progmodes/gud.el (gud-menu-map): Use easy-menu-define. > > Stefan, can you help here? It looks like gud-minor-mode is not a proper > minor mode, Indeed, we should fix that. > so the new code isn't working because gud-minor-mode-map is not > in effect or something? The immediate problem in the patch is that it removed (setf (alist-get 'gud-minor-mode minor-mode-map-alist) gud-minor-mode-map) without replacing it with anything else. Re-adding those 2 lines seems to bring back the previous behavior. Stefan