all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Perry Smith <pedz@easesoftware.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: ruby-ts-mode.el -- first draft
Date: Sat, 10 Dec 2022 23:25:39 -0500	[thread overview]
Message-ID: <jwv5yeio9hv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <065A1DE9-B9BA-4AA3-9D59-D0F5547B8824@easesoftware.com> (Perry Smith's message of "Sat, 10 Dec 2022 21:51:10 -0600")

> (defcustom ruby-ts-indent-tabs-mode nil
>   "Indentation can insert tabs in Ruby TS mode if this is non-nil."
>   :version "29.1"
>   :type 'boolean
>   :safe 'booleanp
>   :group 'ruby)

I'd discourage this practice of duplicating a standard buffer-local
variable <foo> with a <mode>-<foo> config var.

If `add-hook` is too much trouble for Emacs users, then we should devise
a generic way for the users to customize global vars like
`indent-tabs-mode` per-mode without forcing every major mode author to
do it by hand.

> (defcustom ruby-ts-mode-indent-style 'base

I think this var is defined twice in your file.  Did you byte-compile it?
I recommend `flymake-mode`.


        Stefan




  reply	other threads:[~2022-12-11  4:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  3:51 ruby-ts-mode.el -- first draft Perry Smith
2022-12-11  4:25 ` Stefan Monnier [this message]
2022-12-11  7:55 ` Eli Zaretskii
2022-12-11 13:58   ` Perry Smith
2022-12-11 14:55     ` Eli Zaretskii
2022-12-11  8:22 ` Theodor Thornhill
     [not found]   ` <8340D08F-A596-4551-B7B1-B1E63E098E73@easesoftware.com>
2022-12-11 16:26     ` Theodor Thornhill
2022-12-11 16:42       ` Perry Smith
2022-12-11 17:26         ` Bozhidar Batsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv5yeio9hv.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=pedz@easesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.