From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ruby-ts-mode.el -- first draft Date: Sat, 10 Dec 2022 23:25:39 -0500 Message-ID: References: <065A1DE9-B9BA-4AA3-9D59-D0F5547B8824@easesoftware.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23391"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Perry Smith Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 11 05:26:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Dv6-0005tl-GB for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Dec 2022 05:26:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4DuQ-0000td-80; Sat, 10 Dec 2022 23:25:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4DuM-0000tN-S3 for emacs-devel@gnu.org; Sat, 10 Dec 2022 23:25:47 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4DuL-0001YS-3T for emacs-devel@gnu.org; Sat, 10 Dec 2022 23:25:46 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A2BFE1000DC; Sat, 10 Dec 2022 23:25:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1023A1000D5; Sat, 10 Dec 2022 23:25:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670732741; bh=ZZCusp2Q+QTe2DiR+lMUzoEN2Df1yEghm5fdfkFLUew=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W6djwNlmI2iMgi6K6ldN8Eq84oA0JfpQAj51m5EafSl9O9LCr15RmOEGdYaq6a7ep GHbS1V5tQpGVqbddgIrwgRc5YRQO+Ui+a6lfCiI+VC6ddSJbnlzM3nFyQRDXotfnY1 h4ioIFVI5nS2GLcZkrJYo1XWeQku4ixF6BFTUzgFGgfauSiat8ohvc17MNBYYD4Aaz EFEO0ZGbZAib3JsWhpxCQ9BUGxQDvdd+l3J9rgcWgSdosC3/EqL9/6XXg6w8+FhNJd ba03LFG7SxiDRAQl6P7yk/TKOvB+B830qrXnRSPuqoMM3MmcwqlJ+N6gtDC4CJbDIh Fcw743NUAoXLg== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D0A0C1201A2; Sat, 10 Dec 2022 23:25:40 -0500 (EST) In-Reply-To: <065A1DE9-B9BA-4AA3-9D59-D0F5547B8824@easesoftware.com> (Perry Smith's message of "Sat, 10 Dec 2022 21:51:10 -0600") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301140 Archived-At: > (defcustom ruby-ts-indent-tabs-mode nil > "Indentation can insert tabs in Ruby TS mode if this is non-nil." > :version "29.1" > :type 'boolean > :safe 'booleanp > :group 'ruby) I'd discourage this practice of duplicating a standard buffer-local variable with a - config var. If `add-hook` is too much trouble for Emacs users, then we should devise a generic way for the users to customize global vars like `indent-tabs-mode` per-mode without forcing every major mode author to do it by hand. > (defcustom ruby-ts-mode-indent-style 'base I think this var is defined twice in your file. Did you byte-compile it? I recommend `flymake-mode`. Stefan