all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Benjamin Orthen <benjamin@orthen.net>, 63916@debbugs.gnu.org
Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel
Date: Sat, 10 Jun 2023 12:01:04 -0400	[thread overview]
Message-ID: <jwv1qijz55o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874jnf3d0c.fsf@posteo.net> (Philip Kaludercic's message of "Sat,  10 Jun 2023 09:03:31 +0000")

> But if I disable sandboxing, then it works.  The issue appears to be
> that the files under package/use-package are linked in using symlinks,
> but the directory (the emacs checkout) that is being linked to is not
> exposed via bwarp.  If I add that to the ro-binds, then I can build the
> package.  This diff might be enough to resolve the issue:
>
> diff --git a/elpa-admin.el b/elpa-admin.el
> index 24dd16d3cb..81467aa628 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil."
>      "--tmpfs" "/tmp"))
>  
>  (defvar elpaa--sandbox-ro-binds
> -  '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"))
> +  `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"
> +    ,(file-truename (expand-file-name "emacs"))))
[...]
> CC: Stefan, does this look OK to you?

Building of :core packages outside of `elpa.gnu.org` is indeed tested on
very lightly.  In `elpa.gnu.org`, the `emacs` subdirectory is not
a symlink so we avoid that problem.

The above patch feels a bit hackish because it depends on the
directory that happens to be current when the file is loaded.

BTW, you should be able to make the current code work without changing
it, by adding

    (sandbox-extra-ro-dirs "/where/ever/your/emacs/source/dir/is")

to the `elpa-config` file.


        Stefan






  reply	other threads:[~2023-06-10 16:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 21:21 bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Benjamin Orthen
2023-06-10  9:03 ` Philip Kaludercic
2023-06-10 16:01   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-11 10:34     ` Philip Kaludercic
2023-06-11 15:55       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-11 16:37         ` Philip Kaludercic
2023-06-11 16:55           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-11 17:32             ` Benjamin Orthen
2023-09-08 10:55               ` Benjamin Orthen
2023-09-08 17:14                 ` Philip Kaludercic
2023-09-08 19:35                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11  9:58                   ` Benjamin Orthen
2023-09-27 10:53                     ` Benjamin Orthen
2023-09-28 19:52                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1qijz55o.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=63916@debbugs.gnu.org \
    --cc=benjamin@orthen.net \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.