From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Sat, 10 Jun 2023 12:01:04 -0400 Message-ID: References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> <874jnf3d0c.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32851"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Benjamin Orthen , 63916@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 18:02:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q812j-0008LR-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 18:02:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q812W-0006y0-04; Sat, 10 Jun 2023 12:02:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q812R-0006rY-0z for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 12:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q812Q-0004LM-KK for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q812Q-0000Az-1d for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.1686412879615 (code B ref 63916); Sat, 10 Jun 2023 16:02:02 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 10 Jun 2023 16:01:19 +0000 Original-Received: from localhost ([127.0.0.1]:36138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q811i-00009r-I9 for submit@debbugs.gnu.org; Sat, 10 Jun 2023 12:01:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q811f-00009Y-Qv for 63916@debbugs.gnu.org; Sat, 10 Jun 2023 12:01:16 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A8671000BA; Sat, 10 Jun 2023 12:01:10 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1D91410000A; Sat, 10 Jun 2023 12:01:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1686412865; bh=h00uHh1Ro+typbdYY1H0SjsQsuGNlJ3JEM34qmt7KLY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DiLsUV6Q8eif5w4YLEHEIyPbQMveZwAMXWao46zAnyzPDARm7d8WxKUW4KY9/Xosj vQy4F99svDl0ph8Tmp9iLzkwssZc/qrxl5lgM4KNN05jQu65ZiRAdfqv5ZtSdIXxHo ri9cO9P0F9s5UvUxADhebHUc5FD9Y31NaEVkiyyzId89R7mQyL9fkBGcx5chLrcTN6 P/O2ILU/vT/z7l2LUveXFXLUd8DpprpoANKIRjQ4r2y9T1TihjRumEnwf7l2uY36ab WgnkgB0Z2WuFjjrUGTIs8uduqZDDSRiPR2hFKqaNgSE2GAc23Py+urI6vvuO19Qs5k qQEFSvB9uhybw== Original-Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7C7612086B; Sat, 10 Jun 2023 12:01:04 -0400 (EDT) In-Reply-To: <874jnf3d0c.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 10 Jun 2023 09:03:31 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263224 Archived-At: > But if I disable sandboxing, then it works. The issue appears to be > that the files under package/use-package are linked in using symlinks, > but the directory (the emacs checkout) that is being linked to is not > exposed via bwarp. If I add that to the ro-binds, then I can build the > package. This diff might be enough to resolve the issue: > > diff --git a/elpa-admin.el b/elpa-admin.el > index 24dd16d3cb..81467aa628 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil." > "--tmpfs" "/tmp")) > > (defvar elpaa--sandbox-ro-binds > - '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu")) > + `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu" > + ,(file-truename (expand-file-name "emacs")))) [...] > CC: Stefan, does this look OK to you? Building of :core packages outside of `elpa.gnu.org` is indeed tested on very lightly. In `elpa.gnu.org`, the `emacs` subdirectory is not a symlink so we avoid that problem. The above patch feels a bit hackish because it depends on the directory that happens to be current when the file is loaded. BTW, you should be able to make the current code work without changing it, by adding (sandbox-extra-ro-dirs "/where/ever/your/emacs/source/dir/is") to the `elpa-config` file. Stefan