From: Vincent Bernat <bernat@luffy.cx>
To: Stefan Kangas <stefankangas@gmail.com>,
Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: master 52d4c98cec: Fix detection of DPI changes in builds without Xft
Date: Fri, 28 Oct 2022 22:40:16 +0200 [thread overview]
Message-ID: <ec3f5d71-9e96-c304-04d4-4da8ad0caec2@luffy.cx> (raw)
In-Reply-To: <CADwFkmmrK4ozRiXDwAL_-132anDMpjuXiLMWqD2QyTeOp6WDkw@mail.gmail.com>
On 2022-10-28 22:35, Stefan Kangas wrote:
>> branch: master
>> commit 52d4c98cec0901ef5cc1c55d5b3b33ac9d9c519f
>> Author: Vincent Bernat <bernat@luffy.cx>
>> Commit: Eli Zaretskii <eliz@gnu.org>
>>
>> Fix detection of DPI changes in builds without Xft
>>
>> * src/xsettings.c (apply_xft_settings) [!HAVE_XFT]: Support
>> XSETTINGS changes in non-XFT builds. (Bug#43128)
>
> This seems to lead to this warning:
>
> xsettings.c: In function ‘apply_xft_settings’:
> xsettings.c:827:3: warning: implicit declaration of function
> ‘cairo_ft_font_options_substitute’; did you mean
> ‘cairo_font_options_status’? [-Wimplicit-function-declaration]
> 827 | cairo_ft_font_options_substitute (options, pat);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | cairo_font_options_status
> xsettings.c:827:3: warning: nested extern declaration of
> ‘cairo_ft_font_options_substitute’ [-Wnested-externs]
It is defined in cairo-ft.h. The declaration needs to be updated:
#if defined USE_CAIRO || defined HAVE_XFT
#ifdef USE_CAIRO
#include <fontconfig/fontconfig.h>
#include <cairo-ft.h>
#else /* HAVE_XFT */
#include <X11/Xft/Xft.h>
#endif
#endif
next prev parent reply other threads:[~2022-10-28 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166694218940.4562.15928849117026045233@vcs2.savannah.gnu.org>
[not found] ` <20221028072949.AE871C00AB5@vcs2.savannah.gnu.org>
2022-10-28 20:35 ` master 52d4c98cec: Fix detection of DPI changes in builds without Xft Stefan Kangas
2022-10-28 20:40 ` Vincent Bernat [this message]
2022-10-28 21:23 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3f5d71-9e96-c304-04d4-4da8ad0caec2@luffy.cx \
--to=bernat@luffy.cx \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.