From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincent Bernat Newsgroups: gmane.emacs.devel Subject: Re: master 52d4c98cec: Fix detection of DPI changes in builds without Xft Date: Fri, 28 Oct 2022 22:40:16 +0200 Message-ID: References: <166694218940.4562.15928849117026045233@vcs2.savannah.gnu.org> <20221028072949.AE871C00AB5@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 To: Stefan Kangas , Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 07:54:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooenM-0003Vx-HD for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 07:54:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooemV-0004Lg-Vn; Sat, 29 Oct 2022 01:53:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooW9c-0002ap-3D for emacs-devel@gnu.org; Fri, 28 Oct 2022 16:40:43 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooW9Q-0007no-SE; Fri, 28 Oct 2022 16:40:35 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4CC035C01BC; Fri, 28 Oct 2022 16:40:18 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 28 Oct 2022 16:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=luffy.cx; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1666989618; x= 1667076018; bh=f1EYlKmd4yjC4RHdSJTRg79atBCyR86mcjwsblJH0eU=; b=n 9k/hBy1XXNBWXVQicqDMtGAvdlY4fFt4zvwR6jeJbJ4ToraXXzIMJ7TyatCclTBv ogbmZ+/8VLOhI49M2lLov8MQU0i2ty/JV8w1hEajMp3wS6XvJiVcewAGkxG7tdVo BvPgZCsA1Hj1b9g8fgtqcmuR1PZDr4jZYf6Nlyw/2kgvnQgPnLBoe6Av0u+/lvx1 8OGQLlbNbTUEliEfxHcckPXRpviSB8OqIF9mJG3yjRX1Vg9+dYMmowWQVtip5z/g Jx6r8Czw3ovFes1vIRwRbT1GSWeP/blN1KZDy5d3/uJF3zaOt5Df2asbH64DXZP8 zs1vx8pBVSv8ia+7xJYNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1666989618; x=1667076018; bh=f 1EYlKmd4yjC4RHdSJTRg79atBCyR86mcjwsblJH0eU=; b=lYIb5ykmw4a7p4A48 OOPSJgbk+E00TBGkxzLPn5uHaM9EY22XFTO9GnT7c3blg7priq4qj1dkT/2GDS3P /kTBIcZez7vx8179qcdVgKyZHEf26siIj63ZBBqtKcOyxvVx7odEUC09jhi4576j b7TBVSiciusx+N60ksW+Y4TDvvek8Slu9gg/b5EYjbyYR4oNeBmVy8QdTRhnw6u9 bmPkvkifTdroUZ74LzobKbMcHNXFzehZCrsmgy1j8oFDBrPh21aPhQxdilOdbkSN wYlj6lgOnQUknEmnGyKtOeSUd3EYgQ9CgR9XC9vh3CKjNCEbfkIC0qVBLX9fMUNf xPwpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeigdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomhepgghinhgt vghnthcuuegvrhhnrghtuceosggvrhhnrghtsehluhhffhihrdgtgieqnecuggftrfgrth htvghrnhepiedtveefhfdvkedvveegieeljedvjeduueehueffteduffeggeffteeugeet ffeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsg gvrhhnrghtsehluhhffhihrdgtgi X-ME-Proxy: Feedback-ID: i34d144f1:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Oct 2022 16:40:17 -0400 (EDT) Original-Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by neo.luffy.cx (Postfix) with ESMTP id 88391C2; Fri, 28 Oct 2022 22:40:16 +0200 (CEST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=66.111.4.26; envelope-from=bernat@luffy.cx; helo=out2-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 29 Oct 2022 01:37:50 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298716 Archived-At: On 2022-10-28 22:35, Stefan Kangas wrote: >> branch: master >> commit 52d4c98cec0901ef5cc1c55d5b3b33ac9d9c519f >> Author: Vincent Bernat >> Commit: Eli Zaretskii >> >> Fix detection of DPI changes in builds without Xft >> >> * src/xsettings.c (apply_xft_settings) [!HAVE_XFT]: Support >> XSETTINGS changes in non-XFT builds. (Bug#43128) > > This seems to lead to this warning: > > xsettings.c: In function ‘apply_xft_settings’: > xsettings.c:827:3: warning: implicit declaration of function > ‘cairo_ft_font_options_substitute’; did you mean > ‘cairo_font_options_status’? [-Wimplicit-function-declaration] > 827 | cairo_ft_font_options_substitute (options, pat); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | cairo_font_options_status > xsettings.c:827:3: warning: nested extern declaration of > ‘cairo_ft_font_options_substitute’ [-Wnested-externs] It is defined in cairo-ft.h. The declaration needs to be updated: #if defined USE_CAIRO || defined HAVE_XFT #ifdef USE_CAIRO #include #include #else /* HAVE_XFT */ #include #endif #endif