From: Dmitry Gutov <dgutov@yandex.ru>
To: Randy Taylor <dev@rjt.dev>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Which face to use for highlighting interpolation delimiters?
Date: Fri, 6 Jan 2023 15:50:02 +0200 [thread overview]
Message-ID: <dac46395-cd47-8cdb-45e7-bd38a450a891@yandex.ru> (raw)
In-Reply-To: <fVJSuIx8UXnVPvagCnoZ-T6VGAVjpLAWWmdwsm0OmorR-mbPcvtT_6JLTf3-ZLBkPlEhwfey1-rUpYAk5gJQCCtJE_dER6XePRRdibGIJw0=@rjt.dev>
On 06/01/2023 04:56, Randy Taylor wrote:
> On Thursday, January 5th, 2023 at 20:53, Dmitry Gutov <dgutov@yandex.ru> wrote:
>>
>> E.g. ${ and } in "String literal with #{var} in the middle".
>>
>> So far it seems that the ts modes haven't managed to agree on one yet.
>>
>> js-ts-mode uses font-lock-delimiter-face, and
>> typescript-ts-mode uses font-lock-builtin-face (for template_substitution).
>>
>> Maybe we need a new one.
>
> I think font-lock-misc-punctuation-face should be used for those.
Okay.
>> While we're at it, maybe a face for regexp literals as well?
>
> Sure.
Eli, could we still add that in emacs-29? We'll make it simply inherit
from string and use in a 2-3 ts modes for languages with regexp
literals. It's a pretty trivial change.
If we defer it until Emacs 30, it will be kinda painful to use in
ELPA-distributed packages (e.g. python and hopefully ruby as well).
next prev parent reply other threads:[~2023-01-06 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 1:53 Which face to use for highlighting interpolation delimiters? Dmitry Gutov
2023-01-06 2:56 ` Randy Taylor
2023-01-06 13:50 ` Dmitry Gutov [this message]
2023-01-06 14:30 ` Eli Zaretskii
2023-01-06 15:36 ` Dmitry Gutov
2023-01-06 16:48 ` Eli Zaretskii
2023-01-06 17:59 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac46395-cd47-8cdb-45e7-bd38a450a891@yandex.ru \
--to=dgutov@yandex.ru \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.