From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Which face to use for highlighting interpolation delimiters? Date: Fri, 6 Jan 2023 15:50:02 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37302"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: emacs-devel To: Randy Taylor , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 06 14:51:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDn83-0009YC-Jq for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Jan 2023 14:51:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDn6p-0001PN-FW; Fri, 06 Jan 2023 08:50:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDn6n-0001OQ-NH for emacs-devel@gnu.org; Fri, 06 Jan 2023 08:50:09 -0500 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDn6l-0006Nz-JV; Fri, 06 Jan 2023 08:50:09 -0500 Original-Received: by mail-wr1-x42f.google.com with SMTP id bk16so1301200wrb.11; Fri, 06 Jan 2023 05:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=LMX9TdNtONTkOwcb19tp3Uw0qwWFqvtRZcVVe2f6fm0=; b=Wpj7BqDCFk3IaN6rM3lGa3otHYh1yx0LfXFlzx9/5/LkVr/qDiov/dqtxFMLbt6Rng btK/3WwHPANKKiInFopt024iEFObdSVEl7xJS9pgCZRFDxMDkSl19Jr8dR1OFpG/A4xC uh6Eh8njzsJBXogbjVNMZw3XbV2I4X4//aDD38Z1VzHgMGxY6dNh1Hp9LCTuIyc1bwYy cpnz1P9+xzkdSb2U72MtJ7s1kTafHtIn30SnZOeBU1Rcd6HkmGd/1wiorFzCiN0p2Tfb 5AT6lLA8y4B5LVsZzTJWDaf/pl11ccKDnaRtMQUkbzjGvILJUgueq/cfSZZD6YdQsoBO C8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LMX9TdNtONTkOwcb19tp3Uw0qwWFqvtRZcVVe2f6fm0=; b=xbN37ZN63OkSeRV86hoeDtTpR+gmTusQv3fZBcDfN9l8uYqQ2ejhuS4usoh/JVgSVU pNNbDnnXyLZEsAEWCjyY/EZhtZtaxNT/ENoYIugFQw4vJ98Vmb7s8+NiTyLLkxwoS1Iu CzBm5aMDjfCjmc1JyVNa9mGmkuBGV2AMO+CmO+BgNaUl2pMIRKL+NIWGZi3FFWKbyHEg oDWbWq0OhGMiD1C/lI7jt17syi7hcd3FHLCNWd/BCm4o++IBAY2JzJC+plQwpKyMQ2US NyqBRIFM87MknDrT8u4QKxOfBTC5Y5t42kmBPLHBVT5kFRZOpPXofo/i5J4tlz5lTIOG Y9AA== X-Gm-Message-State: AFqh2kqmsIMszL9QfUb4Oc7X0SiPA5TMdDNNkfxbAldHFwq8Eq0LxMsa kEfS2HSWl6U76QYCSy5D1j8= X-Google-Smtp-Source: AMrXdXtCCzbTilXV2h/fFTMSeauPJMTQw+Yr2DJnaUTPzLy1969P32BAS6HdZ5ceBM2WuzxfEZqrMg== X-Received: by 2002:a05:6000:1d87:b0:242:7409:bbf with SMTP id bk7-20020a0560001d8700b0024274090bbfmr30879904wrb.54.1673013004863; Fri, 06 Jan 2023 05:50:04 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q1-20020adff781000000b0027dcc2d6fc3sm1192332wrp.113.2023.01.06.05.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 05:50:03 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.939, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302252 Archived-At: On 06/01/2023 04:56, Randy Taylor wrote: > On Thursday, January 5th, 2023 at 20:53, Dmitry Gutov wrote: >> >> E.g. ${ and } in "String literal with #{var} in the middle". >> >> So far it seems that the ts modes haven't managed to agree on one yet. >> >> js-ts-mode uses font-lock-delimiter-face, and >> typescript-ts-mode uses font-lock-builtin-face (for template_substitution). >> >> Maybe we need a new one. > > I think font-lock-misc-punctuation-face should be used for those. Okay. >> While we're at it, maybe a face for regexp literals as well? > > Sure. Eli, could we still add that in emacs-29? We'll make it simply inherit from string and use in a 2-3 ts modes for languages with regexp literals. It's a pretty trivial change. If we defer it until Emacs 30, it will be kinda painful to use in ELPA-distributed packages (e.g. python and hopefully ruby as well).