From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, 60953@debbugs.gnu.org
Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient
Date: Thu, 26 Jan 2023 21:35:55 +0200 [thread overview]
Message-ID: <d8cf01fa-d829-fe83-0bbf-4a5f1965a107@yandex.ru> (raw)
In-Reply-To: <83sffxcfxw.fsf@gnu.org>
On 26/01/2023 20:24, Eli Zaretskii wrote:
>> Date: Thu, 26 Jan 2023 19:15:51 +0200
>> Cc:60953@debbugs.gnu.org
>> From: Dmitry Gutov<dgutov@yandex.ru>
>>
>> On 26/01/2023 10:10, Eli Zaretskii wrote:
>>> Perhaps Dmitry could present comparison of profiles from perf which
>>> would allow us to understand the reason(s)?
>> I believe I did that in the second message in this thread:
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60953#8
>>
>> To quote the specific profiles, it's
>>
>> 15.30% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_current_status
>> 14.92% emacs emacs [.] process_mark_stack
>> 9.75% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_goto_next_sibling
>> 8.90% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_goto_first_child
>> 3.87% emacs libtree-sitter.so.0.0 [.] ts_node_start_point
>>
>> for :pred vs.
>>
>> 23.72% emacs emacs [.] process_mark_stack
>> 12.33% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_current_status
>> 7.96% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_goto_next_sibling
>> 7.38% emacs libtree-sitter.so.0.0 [.]
>> ts_tree_cursor_goto_first_child
>> 3.37% emacs libtree-sitter.so.0.0 [.] ts_node_start_point
>>
>> for :match.
>>
>> And to continue the quote:
>>
>> Here's a significant jump in GC time which is almost the same as the
>> difference in runtime. And all of it is spent marking?
>>
>> I suppose if the problem is allocation of a large string (many times
>> over), the GC could be spending a lot of time scanning through the
>> memory. Could this be avoided by passing some substitute handle to TS,
>> instead of the full string? E.g. some kind of reference to it in the
>> regexp cache.
> If you are saying that GC is responsible, then running the benchmark
> with gc-cons-threshold set to most-positive-fixnum should produce a
> more interesting profile and perhaps a more interesting comparison.
That really helps:
(benchmark-run 1000 (progn (font-lock-mode -1) (font-lock-mode 1) (let
(treesit--font-lock-fast-mode) (font-lock-ensure))))
=> (16.078430587 251 5.784299419999996)
(let ((gc-cons-threshold most-positive-fixnum)) (benchmark-run 1000
(progn (font-lock-mode -1) (font-lock-mode 1) (let
(treesit--font-lock-fast-mode) (font-lock-ensure)))))
=> (10.369389725 0 0.0)
Do you want a perf profile for the latter? It might not be very useful.
> (But I thought you concluded that GC alone cannot explain the
> difference in performance?)
I'm inclined to think the difference is related to copying of the regexp
string, but whether the time is spent in actually copying it, or
scanning its copies for garbage later, it was harder to say. Seems like
it's the latter, though.
next prev parent reply other threads:[~2023-01-26 19:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 3:53 bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Dmitry Gutov
2023-01-24 4:04 ` Dmitry Gutov
2023-01-25 3:13 ` Yuan Fu
2023-01-25 3:48 ` Dmitry Gutov
2023-01-25 12:49 ` Eli Zaretskii
2023-01-25 23:21 ` Dmitry Gutov
2023-01-26 6:50 ` Eli Zaretskii
2023-01-26 7:17 ` Yuan Fu
2023-01-26 8:10 ` Eli Zaretskii
2023-01-26 17:15 ` Dmitry Gutov
2023-01-26 18:24 ` Eli Zaretskii
2023-01-26 19:35 ` Dmitry Gutov [this message]
2023-01-26 20:01 ` Eli Zaretskii
2023-01-26 21:26 ` Dmitry Gutov
2023-01-30 0:49 ` Dmitry Gutov
2023-01-30 14:06 ` Eli Zaretskii
2023-01-30 14:47 ` Dmitry Gutov
2023-01-30 15:08 ` Eli Zaretskii
2023-01-30 17:15 ` Dmitry Gutov
2023-01-30 17:49 ` Eli Zaretskii
2023-01-30 18:20 ` Dmitry Gutov
2023-01-30 18:42 ` Eli Zaretskii
2023-01-30 19:01 ` Dmitry Gutov
2023-01-30 19:05 ` Eli Zaretskii
2023-01-30 19:58 ` Dmitry Gutov
2023-01-30 23:57 ` Yuan Fu
2023-01-31 0:44 ` Dmitry Gutov
2023-01-31 3:23 ` Eli Zaretskii
2023-01-31 18:16 ` Dmitry Gutov
2023-02-01 2:39 ` Dmitry Gutov
2023-02-01 13:39 ` Eli Zaretskii
2023-02-01 15:13 ` Dmitry Gutov
2023-02-01 21:20 ` Dmitry Gutov
2023-02-02 2:16 ` Yuan Fu
2023-02-02 6:34 ` Eli Zaretskii
2023-02-02 12:12 ` Dmitry Gutov
2023-02-02 14:23 ` Eli Zaretskii
2023-02-02 17:03 ` Dmitry Gutov
2023-02-02 17:26 ` Eli Zaretskii
2023-02-02 17:53 ` Dmitry Gutov
2023-02-02 18:03 ` Eli Zaretskii
2023-02-02 19:44 ` Dmitry Gutov
2023-02-01 13:10 ` Eli Zaretskii
2023-02-01 15:15 ` Dmitry Gutov
2023-01-26 17:12 ` Dmitry Gutov
2023-01-26 18:07 ` Dmitry Gutov
2023-01-26 20:46 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8cf01fa-d829-fe83-0bbf-4a5f1965a107@yandex.ru \
--to=dgutov@yandex.ru \
--cc=60953@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.