PATCH: csharp-mode - improve fontification of typeof() expressions

PATCH: csharp-mode - improve fontification of typeof() expressions

[Jostein Kjønigsen]

[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

Hey everyone.

As I promised in my earlier mail on this list, I'd still love to keep 
contributing.

As such, here's a small patch which improves fontification of C# 
typeof() expressions. Is it OK as is, or does anyone see the need for 
anything additional to get this merged?

-- 
Kind regards
*Jostein Kjønigsen*

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no <https://jostein.kjønigsen.no>

[-- Attachment #1.2: Type: text/html, Size: 890 bytes --]

[-- Attachment #2: 0001-Csharp-Correctly-fontify-types-in-typeof-expression.patch --]
[-- Type: text/x-patch, Size: 960 bytes --]

From 7280c25f0753ed18a1d74e64b26e80e038e29739 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein@kjonigsen.net>
Date: Fri, 25 Nov 2022 20:15:06 +0100
Subject: [PATCH] Csharp: Correctly fontify types in typeof() expression.

---
 lisp/progmodes/csharp-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index af3a4d86da2..11fa951048e 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -806,7 +806,8 @@ csharp-ts-mode--font-lock-settings
      (cast_expression (identifier) @font-lock-type-face)
      ["operator"] @font-lock-type-face
      (type_parameter_constraints_clause
-      target: (identifier) @font-lock-type-face))
+      target: (identifier) @font-lock-type-face)
+     (type_of_expression (identifier) @font-lock-type-face))
    :language 'c-sharp
    :feature 'definition
    :override t
-- 
2.37.2

Re: PATCH: csharp-mode - improve fontification of typeof() expressions

[Yuan Fu]

> On Nov 25, 2022, at 12:02 PM, Jostein Kjønigsen <jostein@secure.kjonigsen.net> wrote:
> 
> Hey everyone.
> 
> As I promised in my earlier mail on this list, I'd still love to keep contributing.
> 
> As such, here's a small patch which improves fontification of C# typeof() expressions. Is it OK as is, or does anyone see the need for anything additional to get this merged?
> 

Thanks Jostein, I applied your patch.

Yuan