bug#66210: 30.0.50; Missing choices in type-break.el

bug#66210: 30.0.50; Missing choices in type-break.el

[Mauro Aranda]

Docstring of type-break-good-rest-interval says it can be nil, just like
type-break-good-break-interval.  But its :type is just natnum.

Also, type-break-file-name says it can be nil to avoid saving data, but
its :type is just file.

bug#66210: 30.0.50; Missing choices in type-break.el

[Mauro Aranda]

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

tags 66210 patch
quit


Patch attached.

[-- Attachment #2: 0001-Fix-defcustoms-in-type-break.el-Bug-66210.patch --]
[-- Type: text/x-patch, Size: 1370 bytes --]

From 0e5922906ae80a1a5d486587ac35468de83720fc Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Tue, 26 Sep 2023 09:17:14 -0300
Subject: [PATCH] Fix defcustoms in type-break.el (Bug#66210)

* lisp/type-break.el (type-break-good-rest-interval)
(type-break-file-name): Allow nil.
---
 lisp/type-break.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/type-break.el b/lisp/type-break.el
index 494ed80c496..d3371d66863 100644
--- a/lisp/type-break.el
+++ b/lisp/type-break.el
@@ -77,7 +77,8 @@ type-break-good-rest-interval
 If a break is interrupted before this much time elapses, the user will be
 asked whether or not really to interrupt the break."
   :set-after '(type-break-interval)
-  :type 'natnum
+  :type '(choice (const :tag "Don't check idle time" nil)
+                 natnum)
   :group 'type-break)
 
 (defcustom type-break-good-break-interval nil
@@ -201,7 +202,8 @@ type-break-file-name
   "Name of file used to save state across sessions.
 If this is nil, no data will be saved across sessions."
   :version "24.4"                       ; added locate-user
-  :type 'file)
+  :type '(choice (const :tag "Don't save data" nil)
+                 file))
 
 (defvar type-break-post-command-hook '(type-break-check)
   "Hook run indirectly by `post-command-hook' for typing break functions.
-- 
2.34.1

bug#66210: 30.0.50; Missing choices in type-break.el

[Stefan Kangas]

Version: 29.2

Mauro Aranda <maurooaranda@gmail.com> writes:

> tags 66210 patch
> quit
>
>
> Patch attached.

Thanks, installed on emacs-29.

[1: 4fd00ff1f7e]: 2023-10-01 01:49:50 +0200
  Fix defcustoms in type-break.el (Bug#66210)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fd00ff1f7e7183cf1e4fa864ba83bc646a5356f