all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Morgan Smith <Morgan.J.Smith@outlook.com>,
	Stefan Kangas <stefankangas@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57367-done@debbugs.gnu.org
Subject: bug#57367: [PATCH v3] Speed up em-smart
Date: Sat, 28 Oct 2023 15:47:52 -0700	[thread overview]
Message-ID: <b6a0aa04-b8e5-da0a-3313-d2eb2211f562@gmail.com> (raw)
In-Reply-To: <DM5PR03MB3163467A7534D545C4A2E6BCC5D5A@DM5PR03MB3163.namprd03.prod.outlook.com>

Version: 30.1

On 10/18/2023 8:46 AM, Morgan Smith wrote:
> Thanks for the ping.  Reading the documentation for
> `window-configuration-change-hook' I found out I can run the scroll
> command only on updated windows.  Furthermore, that hook selects the
> window which is nice.  I believe the problems pointed out above stem
> from using `(point)` to scroll a window that wasn't actually selected.
> 
> Anyways here is V3

Thanks for the updated patch. As far as I can tell (I don't use the 
smart display module in Eshell), everything works here, and you even 
fixed a bug I noticed on master with long output! (Previously, if you 
ran a command with a lot of output, the prompt got hidden for some 
reason, probably due to using field properties for the prompt/output. 
That's fixed now.)

I've merged this to master as e08238cdd74 now. Closing this bug. Thanks 
again.





      reply	other threads:[~2023-10-28 22:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 20:06 bug#57367: [PATCH] Speed up em-smart Morgan Smith
2022-09-04 21:56 ` Lars Ingebrigtsen
2022-09-05 19:01   ` Jim Porter
2022-09-05 21:48     ` Morgan Smith
2022-09-05 21:51       ` Lars Ingebrigtsen
     [not found]         ` <DM5PR03MB31639CBC75F62622AC4E70ABC57E9@DM5PR03MB3163.namprd03.prod.outlook.com>
2022-09-06 10:00           ` Lars Ingebrigtsen
2022-09-07  1:30             ` bug#57367: [PATCH V2] " Morgan Smith
2022-09-07 12:55               ` Lars Ingebrigtsen
2022-09-09  4:36               ` Jim Porter
2023-09-06 22:46                 ` bug#57367: [PATCH] " Stefan Kangas
2023-10-18 15:46                   ` bug#57367: [PATCH v3] " Morgan Smith
2023-10-28 22:47                     ` Jim Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6a0aa04-b8e5-da0a-3313-d2eb2211f562@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=57367-done@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=larsi@gnus.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.