From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57367: [PATCH v3] Speed up em-smart Date: Sat, 28 Oct 2023 15:47:52 -0700 Message-ID: References: <87r10q6byc.fsf@gnus.org> <9257e0e5-232e-7e20-f4d1-385066c4337e@gmail.com> <87bkrtxzfj.fsf@gnus.org> <87ilm0x1ol.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25709"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 57367-done@debbugs.gnu.org To: Morgan Smith , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 00:48:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qws6s-0006Yg-35 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 00:48:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qws6b-0007v1-C8; Sat, 28 Oct 2023 18:48:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qws6Z-0007tm-85 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 18:48:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qws6Y-0007qO-Vu for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 18:48:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qws75-0000pw-6I for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 18:49:03 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2023 22:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Mail-Followup-To: 57367@debbugs.gnu.org, jporterbugs@gmail.com, Morgan.J.Smith@outlook.com Original-Received: via spool by 57367-done@debbugs.gnu.org id=D57367.16985333132950 (code D ref 57367); Sat, 28 Oct 2023 22:49:03 +0000 Original-Received: (at 57367-done) by debbugs.gnu.org; 28 Oct 2023 22:48:33 +0000 Original-Received: from localhost ([127.0.0.1]:39828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qws6b-0000lU-51 for submit@debbugs.gnu.org; Sat, 28 Oct 2023 18:48:33 -0400 Original-Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]:47612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qws6Z-0000ki-J5 for 57367-done@debbugs.gnu.org; Sat, 28 Oct 2023 18:48:32 -0400 Original-Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-586a5d76413so1832802eaf.3 for <57367-done@debbugs.gnu.org>; Sat, 28 Oct 2023 15:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698533273; x=1699138073; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=guciBZd1bHzSkqtvOXAINny9LtsywSg9o4zGmBGY4t0=; b=kOwMO0keDm5bT43yTjG2GbXJAUBCMyby1o/23OM/LwvZJ2eEkeEDbfgFzk+lO7wEfG +a6qRobyjg+h+igVqU2JH84BRnSwfpxs+Plh+EymKB3sryp0BQIQPR81iwHneXQENM7w hfMUul0+7bomlrgSS2myq0iyxLcD/KCm129xHmq3CGM/rlcCQmhUUrWbMeXn3HajYjYk eqtmBtx23XGBg2INH4WacAZTHvyKvGVVOex3U9JMMUZqmIKLuYaXblJ8+mCkntuf2+oN rjrEOgzyXvZI7IWiK1SOg58jFXNfrV/e5mpU3xpp0crWVMAVL41gToCmddS2wXvLrSYy H3Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698533273; x=1699138073; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=guciBZd1bHzSkqtvOXAINny9LtsywSg9o4zGmBGY4t0=; b=T6rNbcuJc8mEWML2IfGeEoZbs39tUYHVZa9aJ8m2a0Gr+QNuIdcfdKuffiEpQpKTdM A5O10VpfslKSII7cgVvtA8qVKyQKecNhkFn8MPDUeJkVvsgjJNPRiiiWJlN0rpHoKC32 cW2Ids9B3gPmiwGJwLVqUKTLjKloqs45drhqgCycTn9iLFBVTyfk0Wo4ldFzS7TtvtFb QBzEOu8WMJfskA+QaXLEmhTQIFQT4KVQPJnJf4/yi2bfylo/lhdt2vPW3R+4T1K2OorH lXPS0XXV0Wr3enMnlIMfbi5keIom6SItV2dhsPBT5/+T+dKinWVYDFDHAXafNg6FLfQN yfCw== X-Gm-Message-State: AOJu0YxchLnQKXQ/m/wJUWx/VCDBG6l5VaVYLCSVn0FXAyPN0K3BIVbS FLg3Q3HKnQsrzzvcG8RWBBU= X-Google-Smtp-Source: AGHT+IHWOj72N7ns8mqoBZ/10DYi3RbIkSBCWLofVEISxv4vcwrwlbroH3ocPt757/ClF6BkLLL1ow== X-Received: by 2002:aca:1b07:0:b0:3ab:84f0:b491 with SMTP id b7-20020aca1b07000000b003ab84f0b491mr6945827oib.19.1698533273554; Sat, 28 Oct 2023 15:47:53 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 29-20020a17090a199d00b0027ffff956bcsm163723pji.47.2023.10.28.15.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Oct 2023 15:47:53 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273473 Archived-At: Version: 30.1 On 10/18/2023 8:46 AM, Morgan Smith wrote: > Thanks for the ping. Reading the documentation for > `window-configuration-change-hook' I found out I can run the scroll > command only on updated windows. Furthermore, that hook selects the > window which is nice. I believe the problems pointed out above stem > from using `(point)` to scroll a window that wasn't actually selected. > > Anyways here is V3 Thanks for the updated patch. As far as I can tell (I don't use the smart display module in Eshell), everything works here, and you even fixed a bug I noticed on master with long output! (Previously, if you ran a command with a lot of output, the prompt got hidden for some reason, probably due to using field properties for the prompt/output. That's fixed now.) I've merged this to master as e08238cdd74 now. Closing this bug. Thanks again.