From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59935@debbugs.gnu.org, juri@linkov.net
Subject: bug#59935: 29.0.60; project-list-buffers is slow
Date: Sun, 11 Dec 2022 12:23:13 +0200 [thread overview]
Message-ID: <ada55c92-c86f-7bbd-ae84-d9dd1f1348f3@yandex.ru> (raw)
In-Reply-To: <83v8miv4x2.fsf@gnu.org>
On 11/12/2022 08:19, Eli Zaretskii wrote:
>> Date: Sat, 10 Dec 2022 22:23:01 +0200
>> Cc: 59935@debbugs.gnu.org, juri@linkov.net
>> From: Dmitry Gutov <dgutov@yandex.ru>
>>
>> On 10/12/2022 22:11, Eli Zaretskii wrote:
>>> I see this in emacs-29:
>>>
>>> (setq-local revert-buffer-function
>>> (lambda (&rest _ignored)
>>> (list-buffers--refresh (project-buffers pr))
>>> (tabulated-list-print t))))
>>>
>>> So I still don't understand your fears.
>>
>> That's the (version< emacs-version "29.0.50") branch.
>
> Still unclear. It almost looks like you don't _want_ me to
> understand. A detailed explanation with code fragments would be much
> more effective.
I think I've explained everything, and we are now going in circles. Why
not look at the definition yourself? It's 12 lines.
The function has two execution branches: one for the latest Emacs (at
the moment), and one (the largest one) for older Emacsen.
The main problematic behavior (low performance) is exhibited by the
"latest" branch, which looks like this:
(let ((pr (project-current t)))
(display-buffer
(if (version< emacs-version "29.0.50")
;; ...
(list-buffers-noselect
arg nil (lambda (buf) (memq buf (project-buffers pr)))))))
> Anyway, I only entered this discussion because you asked about making
> some non-trivial changes on the release branch. If that is no longer
> an issue, I will gladly bow out of this.
I expect Juri is going to argue for that later. For non-trivial changes
in buff-menu.el, no less.
next prev parent reply other threads:[~2022-12-11 10:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 1:49 bug#59935: 29.0.60; project-list-buffers is slow Dmitry Gutov
2022-12-10 2:03 ` Dmitry Gutov
2022-12-10 8:11 ` Eli Zaretskii
2022-12-10 10:47 ` Dmitry Gutov
2022-12-10 11:12 ` Eli Zaretskii
2022-12-10 11:37 ` Dmitry Gutov
2022-12-10 14:33 ` Eli Zaretskii
2022-12-10 19:19 ` Dmitry Gutov
2022-12-10 19:42 ` Eli Zaretskii
2022-12-10 19:53 ` Dmitry Gutov
2022-12-10 20:11 ` Eli Zaretskii
2022-12-10 20:23 ` Dmitry Gutov
2022-12-11 6:19 ` Eli Zaretskii
2022-12-11 10:23 ` Dmitry Gutov [this message]
2022-12-11 10:54 ` Eli Zaretskii
2022-12-11 16:32 ` Dmitry Gutov
2022-12-12 10:36 ` Jean Louis
2022-12-12 17:12 ` Juri Linkov
2022-12-13 3:10 ` Jean Louis
2022-12-12 19:58 ` Dmitry Gutov
2022-12-13 3:10 ` Jean Louis
2022-12-13 15:29 ` Dmitry Gutov
2022-12-13 19:30 ` Jean Louis
2022-12-13 20:31 ` Dmitry Gutov
2022-12-15 14:58 ` Jean Louis
2022-12-15 15:12 ` Dmitry Gutov
2022-12-10 17:45 ` Juri Linkov
2022-12-10 19:22 ` Dmitry Gutov
2022-12-11 17:07 ` Juri Linkov
2022-12-11 17:49 ` Eli Zaretskii
2022-12-11 17:56 ` Juri Linkov
2022-12-11 18:08 ` Eli Zaretskii
2022-12-11 18:13 ` Dmitry Gutov
2022-12-11 18:12 ` Dmitry Gutov
2022-12-11 18:17 ` Eli Zaretskii
2022-12-11 18:35 ` Dmitry Gutov
2022-12-11 19:00 ` Eli Zaretskii
2022-12-11 19:41 ` Dmitry Gutov
2022-12-11 20:42 ` Eli Zaretskii
2022-12-12 17:16 ` Juri Linkov
2022-12-12 17:27 ` Eli Zaretskii
2022-12-12 17:51 ` Juri Linkov
2022-12-12 18:10 ` Eli Zaretskii
2022-12-12 18:14 ` Juri Linkov
2022-12-12 18:22 ` Eli Zaretskii
2022-12-13 17:49 ` Juri Linkov
2022-12-11 18:37 ` Dmitry Gutov
2022-12-13 17:49 ` Juri Linkov
2022-12-13 18:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada55c92-c86f-7bbd-ae84-d9dd1f1348f3@yandex.ru \
--to=dgutov@yandex.ru \
--cc=59935@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.