From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 12:23:13 +0200 Message-ID: References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> <83v8miv4x2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 11:24:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4JVI-0000Nz-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 11:24:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4JV7-0004hD-9f; Sun, 11 Dec 2022 05:24:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4JV5-0004gk-D5 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4JV4-00016G-V8 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4JV4-0008PN-OO for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167075420432288 (code B ref 59935); Sun, 11 Dec 2022 10:24:02 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 10:23:24 +0000 Original-Received: from localhost ([127.0.0.1]:46286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4JUS-0008Oi-7O for submit@debbugs.gnu.org; Sun, 11 Dec 2022 05:23:24 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:36358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4JUP-0008Oa-T1 for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 05:23:23 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so2840945wma.1 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 02:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=K/rs4VbQ/jlPI9OcW+U//HmQpQsqLEwHtZrsoFKZ30k=; b=nyRNEDhnM7MPidQg8B6dhNS2g26TfrbINcvH/5Y7KewAC9nLEqkQ/Zk8ZvJH9iyw1N u/ylnCX76O8sXF5WRKaD7NclJE/9OxJetLr5uPSom3B+gPwxy14FmDxyRttUTTb+098v sixeMSwHvahIa1bhFFRuN8Mnn8YUQRsNPTZhbf2tROOD2/uTUP0wTTRHHydbdQ80nytj zTqV7CKecWAi6sliIE6O/IABsdszFbk5V2ucOMkrzM4NaSfzl2Gtiz8NA7v7eVp3+Awo 5mH+uswVybZUHfHBnEehGXDZU2CXjrtivnHjD6Uq0z+1qEhXKmblaQyOYtmY7X5qLqFO k5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K/rs4VbQ/jlPI9OcW+U//HmQpQsqLEwHtZrsoFKZ30k=; b=rVE8pvic2Lq6VpcYw9nifxbRmlBqGH0ICjoDMbe+Z1IaBL3nAEueFWf8+16zgk531Y WlsJKIsC2MKuC7MruY5g5hu6UKS7ex6sB08IoxHnHPaLXrUBhjUiTW2L7BlfQv6bIrv0 vOkobo8DDtlvm++ZM2VZr0dHssLTbCc5eJs8z0DAguDuBqNvKrTb9E5YrDnGUZ8lR9R+ S/rwbtKLmInzhbSEI+kvJdR2e9A3RtZq4awf5a6vhS5Xkz4Ub34KxNYWXDrr9coopaWL 6kqlRWLlfHIcZ7pxy7ScZDG9ehOAZTob5kl1xqCxFbkNZopIMy3fjgq7VD7keT2gMVe0 9xFA== X-Gm-Message-State: ANoB5pmHVUQDUa/yMz2es2OdADwBXoYxLbeHEvsKCbUSI6mLerJk9yD4 ifDBPpnDLjVTGJp4yQilQFc= X-Google-Smtp-Source: AA0mqf6PZU5Rmnclmx66QsjmReT9ZKv0Op3JmhyS78yB+5FZSi83UXeDFZ1kbdB1PwuI7aWOizA+PA== X-Received: by 2002:a7b:c30e:0:b0:3cf:7397:c768 with SMTP id k14-20020a7bc30e000000b003cf7397c768mr9652219wmj.30.1670754195797; Sun, 11 Dec 2022 02:23:15 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p17-20020a05600c359100b003c6b7f5567csm21236259wmq.0.2022.12.11.02.23.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 02:23:15 -0800 (PST) Content-Language: en-US In-Reply-To: <83v8miv4x2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250587 Archived-At: On 11/12/2022 08:19, Eli Zaretskii wrote: >> Date: Sat, 10 Dec 2022 22:23:01 +0200 >> Cc: 59935@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> On 10/12/2022 22:11, Eli Zaretskii wrote: >>> I see this in emacs-29: >>> >>> (setq-local revert-buffer-function >>> (lambda (&rest _ignored) >>> (list-buffers--refresh (project-buffers pr)) >>> (tabulated-list-print t)))) >>> >>> So I still don't understand your fears. >> >> That's the (version< emacs-version "29.0.50") branch. > > Still unclear. It almost looks like you don't _want_ me to > understand. A detailed explanation with code fragments would be much > more effective. I think I've explained everything, and we are now going in circles. Why not look at the definition yourself? It's 12 lines. The function has two execution branches: one for the latest Emacs (at the moment), and one (the largest one) for older Emacsen. The main problematic behavior (low performance) is exhibited by the "latest" branch, which looks like this: (let ((pr (project-current t))) (display-buffer (if (version< emacs-version "29.0.50") ;; ... (list-buffers-noselect arg nil (lambda (buf) (memq buf (project-buffers pr))))))) > Anyway, I only entered this discussion because you asked about making > some non-trivial changes on the release branch. If that is no longer > an issue, I will gladly bow out of this. I expect Juri is going to argue for that later. For non-trivial changes in buff-menu.el, no less.