Re: Would (Eval-when-compile (require 'treesit)) eliminate the need for (declare-function)s?

[Yuan Fu <casouri@gmail.com>]

> 
> IIUC one way to look at this is that `treesit.el` wants to "re-export"
> the functions provided by `treesit.c` so users of `treesit.el` don't
> need to know whether the function they call is implemented in C or
> in ELisp?

Not quite IMO, see below.

>> 
>>> Even if it does work reliably, I'm not sure we want that.  It is
>>> better to have declare-function where the function is used, as that
>>> makes maintenance easier and less error-prone.
>> 
>> But it makes sense for packages that do
>> 
>>    (require 'treesit)
>> 
>> to be able to use those functions implemented in `treesit.c` without
>> bothering with `declare-function`.
> 
> That's what I'm not sure about.

If emacs isn’t built with tree-sitter it doesn’t make much sense to use functions in treesit.c anyway. The real problem is that some files need to be byte-compiled even when emacs isn’t built with tree-sitter. And it’s easy to miss adding declare-function’s. 

Is there any other way to help the situation that we can do in Lisp? Ie, without making all functions always defined in treesit.c? Because I played it in my head a bit, and it looks really messy.

Yuan