all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: Eli Zaretskii <eliz@gnu.org>, 59490@debbugs.gnu.org
Subject: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 13:19:21 -0800	[thread overview]
Message-ID: <E3E81D08-3CFA-4209-9902-14B472190599@gmail.com> (raw)
In-Reply-To: <B9D3FF70-835B-4F68-9672-590214D28E6A@thornhill.no>



> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill <theo@thornhill.no> wrote:
> 
> 
> 
> On 23 November 2022 21:38:19 CET, Yuan Fu <casouri@gmail.com> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> 
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>> 
>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>>> 
>>>>> Ok so this works.
>>>>> 
>>>>> Sorry for the mess.
>>>>> 
>>>>> What do you think?
>>>> 
>>>> LGTM, thanks.  I'll let Yuan review and install.
>>> 
>>> Thanks Theo! I’ve merged it. One general comment is that we should have
>>> a "standard" list of features consistent across major modes. I think by
>>> now we’ve worked on font-lock enough to know what those features should
>>> be. I’ll start a discussion on the ML.
>> 
>> Actually, another thing: it seems the mode defined is still named
>> csharp-mode rather than csharp-cc-mode.
>> 
>> Yuan
> 
> Yeah that's right. Imo that's ok, because it's unlikely there will be much new development on the cc mode variant. So it will be identical to the upstream one, and the upstream one will be marked as deprecated very soon.
> 
> What do you think?

Yeah I was just confused because you said

> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The cc-mode
> variant has that name as to not conflict with the ELPA package.

And I only see csharp-mode.

So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then I assume this line is a typo?

;;;###autoload
(add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode))

Yuan






  reply	other threads:[~2022-11-23 21:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 20:52 bug#59490: 29.0.50; Add C# support Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-22 21:25 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found] ` <handler.59490.B.166915036216965.ack@debbugs.gnu.org>
2022-11-22 21:47   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 12:16     ` Eli Zaretskii
2022-11-23 18:29 ` Yuan Fu
2022-11-23 18:44   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 20:38 ` Yuan Fu
2022-11-23 20:43   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 21:19     ` Yuan Fu [this message]
2022-11-23 21:25       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 23:03         ` Yuan Fu
2022-11-24  6:25   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E3E81D08-3CFA-4209-9902-14B472190599@gmail.com \
    --to=casouri@gmail.com \
    --cc=59490@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.