From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59490: 29.0.50; Add C# support Date: Wed, 23 Nov 2022 13:19:21 -0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59490@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 22:20:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxxAU-0007Lm-LP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 22:20:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxxA4-0006tk-Jz; Wed, 23 Nov 2022 16:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxxA2-0006sq-GR for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxxA2-0000XK-8s for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxxA1-0008T9-Ov for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 21:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59490 X-GNU-PR-Package: emacs Original-Received: via spool by 59490-submit@debbugs.gnu.org id=B59490.166923837332510 (code B ref 59490); Wed, 23 Nov 2022 21:20:01 +0000 Original-Received: (at 59490) by debbugs.gnu.org; 23 Nov 2022 21:19:33 +0000 Original-Received: from localhost ([127.0.0.1]:56421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxx9Z-0008SF-Ad for submit@debbugs.gnu.org; Wed, 23 Nov 2022 16:19:33 -0500 Original-Received: from mail-pg1-f181.google.com ([209.85.215.181]:45748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxx9V-0008S0-OT for 59490@debbugs.gnu.org; Wed, 23 Nov 2022 16:19:32 -0500 Original-Received: by mail-pg1-f181.google.com with SMTP id r18so17780212pgr.12 for <59490@debbugs.gnu.org>; Wed, 23 Nov 2022 13:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=//S/hwKRy4gMGC8KNhag1YjktdekgJpzHAiA4kQMZ+c=; b=gpZigJk83QfICLW1h7V+uBMiA4cEdRHd3CUtmv/qGBD+DWXqYiw+xCDYouajQqpl6C BO9jdEVSuLDcfKx624DDS4dvSmk2m3oHOmRWVtr7xoGIfW44P3IZhAKqNlWAx1qzkxsW C3vXMMCOTXFvC2Kt72pEtxzZL+IqzAqXwI5pI+ycgOtoxdNaowZt6ZmQj4hlllwDJGHA /tNSnpeG6x50OjgDc6uBDDIL+zUaBI1EBbyuCG4EA8dLhq8M1HzWoCgeTqFq308CfxGj VaV6NFuHdgQ4Ip+p/U4pBKbnLDT7BeUp4mCfn2wIkD0QeV7KZGsY+dpE7f7biocJiUJA JpWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=//S/hwKRy4gMGC8KNhag1YjktdekgJpzHAiA4kQMZ+c=; b=puI8Za+8aWESVvVi1MYnttjIStrnRYaV9AXW/Ne3u5zSHsEv9iJ78WuAAVWR0aWsGV 1tNVsrkdQebwiwFbP/ReiayDWe2hjVYSSwLK0Ce/xdI7xc3vacsKHdyh3YP6fjQa6mD3 qz3/wvQeHbS/baeqEArzFzSjsMk/c6GU0t+tXcEdTLBykF9cPfdZTt/8YLJBR+YvSDIG v9zKiWrynE7OWjBj1AKae9aULmRv+LZZ4qKEksbkHRv13msXKE5HJwFwU/jfKc78nLTD WCaxqymblZ6ACNkP1X70RVg4jBOYhIe5zgMpB71fPBVCYQ2rlbD69hOghuUrsCg+WbS5 yMBA== X-Gm-Message-State: ANoB5plOzRvTPg6KHI5Dn/NrxIS7/YUmKwkbxlMcGgFYuPwFiO0fDVZe XRe+I13AsNUNdnz53u6u7DI= X-Google-Smtp-Source: AA0mqf63G/UIT+tI8IqGTb9JwZwE2EhPd5uE0E/Mbqz2lt2BcMHTgoCJ8BfJ2k1KfCXq2+7g9JF5Hg== X-Received: by 2002:a63:de01:0:b0:476:32a2:253 with SMTP id f1-20020a63de01000000b0047632a20253mr12036271pgg.133.1669238363623; Wed, 23 Nov 2022 13:19:23 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ik18-20020a170902ab1200b001767f6f04efsm4094595plb.242.2022.11.23.13.19.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2022 13:19:23 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248788 Archived-At: > On Nov 23, 2022, at 12:43 PM, Theodor Thornhill = wrote: >=20 >=20 >=20 > On 23 November 2022 21:38:19 CET, Yuan Fu wrote: >>=20 >> Yuan Fu writes: >>=20 >>> Eli Zaretskii writes: >>>=20 >>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100 >>>>> From: Theodor Thornhill via "Bug reports for GNU Emacs, >>>>> the Swiss army knife of text editors" >>>>>=20 >>>>> Ok so this works. >>>>>=20 >>>>> Sorry for the mess. >>>>>=20 >>>>> What do you think? >>>>=20 >>>> LGTM, thanks. I'll let Yuan review and install. >>>=20 >>> Thanks Theo! I=E2=80=99ve merged it. One general comment is that we = should have >>> a "standard" list of features consistent across major modes. I think = by >>> now we=E2=80=99ve worked on font-lock enough to know what those = features should >>> be. I=E2=80=99ll start a discussion on the ML. >>=20 >> Actually, another thing: it seems the mode defined is still named >> csharp-mode rather than csharp-cc-mode. >>=20 >> Yuan >=20 > Yeah that's right. Imo that's ok, because it's unlikely there will be = much new development on the cc mode variant. So it will be identical to = the upstream one, and the upstream one will be marked as deprecated very = soon. >=20 > What do you think? Yeah I was just confused because you said > I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The = cc-mode > variant has that name as to not conflict with the ELPA package. And I only see csharp-mode. So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then = I assume this line is a typo? ;;;###autoload (add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode)) Yuan