From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Gerd Möllmann" <gerd.moellmann@gmail.com>,
"Dmitry Gutov" <dmitry@gutov.dev>, "Eli Zaretskii" <eliz@gnu.org>,
68244@debbugs.gnu.org, "Stefan Kangas" <stefankangas@gmail.com>
Subject: bug#68244: hash-table improvements
Date: Mon, 12 Feb 2024 13:16:44 +0100 [thread overview]
Message-ID: <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@gmail.com> (raw)
In-Reply-To: <jwvr0hmq21z.fsf-monnier+emacs@gnu.org>
8 feb. 2024 kl. 18.49 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>> And you are right about the need for vector compatibility, just discovered
>> that the hard way.
>
> Welcome to the club :-)
And to show that I'm repeating all your mistakes and ignoring your hard-won wisdom, I made a patch for PVEC_OBARRAY.
* It does give a nice speed-up, not only in microbenchmarks. Relint on the Emacs directory tree sees a speed-up of 5 % which is not bad considering how much work that code does.
* Contrary to your suggestion I went with an entirely new type, which means that:
- obarray objects grow automatically and use the same faster hashing (Knuth) as hash tables
- `obarrayp` is now true for both obarray objects and vectors; `obarray-object-p` detects the new type only.
- `obarray-make` now produces an obarray object.
- All old built-in functions that take an obarray now accept both vectors and obarray objects
- New function `obarray-clear` to replace code that filled vectors with 0
* Compatibility with existing code is excellent except for some places that used `obarray-make` but then assumed the result to be vectors (using `vectorp` instead of `obarrayp` etc).
Your suggestion to represent obarrays as a single-element vector containing an actual object (PVEC_OBARRAY or a hash table) would kind of help here but it still seems like a half-measure and perpetuates some problems that we would like to avoid with a new type.
Maybe a different kind of compromise would be better: `obarray-make` is kept unchanged as make-vector (but deprecated), and a new `make-obarray` (for example) creates the new objects.
Oh, and there is a small glitch in the existing code: when a symbol is uninterned, its status is set to SYMBOL_UNINTERNED, but if its containing obarray is GCed away or manually cleared then this doesn't happen. This is probably not worth fixing but at least with PVEC_OBARRAY we could if we wanted to.
next prev parent reply other threads:[~2024-02-12 12:16 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org>
[not found] ` <20240104155642.B4A99C00344@vcs2.savannah.gnu.org>
2024-01-04 17:32 ` scratch/hash-table-perf 2d28042f56a 19/35: Use non-Lisp allocation for internal hash-table vectors Dmitry Gutov
2024-01-05 10:33 ` bug#68244: hash-table improvements Mattias Engdegård
2024-01-05 15:41 ` Dmitry Gutov
2024-01-06 11:34 ` Mattias Engdegård
2024-01-06 11:51 ` Eli Zaretskii
2024-01-07 3:13 ` Dmitry Gutov
2024-01-07 5:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 15:39 ` Dmitry
2024-01-07 18:36 ` Mattias Engdegård
2024-01-07 19:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 18:26 ` Mattias Engdegård
2024-01-09 0:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 10:26 ` Mattias Engdegård
2024-01-13 20:06 ` Mattias Engdegård
2024-01-04 16:27 ` Mattias Engdegård
2024-01-04 16:39 ` Eli Zaretskii
2024-01-04 17:02 ` Mattias Engdegård
2024-01-04 17:45 ` Eli Zaretskii
2024-01-05 11:34 ` Mattias Engdegård
2024-01-05 17:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 11:46 ` Mattias Engdegård
2024-01-09 21:51 ` Stefan Kangas
2024-01-12 15:42 ` Mattias Engdegård
2024-01-14 22:08 ` Andy Moreton
2024-01-15 12:31 ` Eli Zaretskii
2024-01-15 13:26 ` Mattias Engdegård
2024-01-18 18:13 ` Mattias Engdegård
2024-01-15 20:01 ` Andy Moreton
2024-01-15 20:21 ` Eli Zaretskii
2024-01-16 21:57 ` Andy Moreton
2024-01-17 3:31 ` Eli Zaretskii
2024-01-18 20:29 ` Andy Moreton
2024-01-19 6:37 ` Eli Zaretskii
2024-01-20 20:20 ` Andy Moreton
2024-01-21 5:11 ` Eli Zaretskii
2024-01-21 13:03 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-22 9:17 ` João Távora
2024-01-22 9:18 ` João Távora
2024-01-23 9:44 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 5:25 ` Gerd Möllmann
2024-01-14 14:42 ` Mattias Engdegård
2024-01-21 12:41 ` Stefan Kangas
2024-02-08 9:46 ` Mattias Engdegård
2024-02-08 14:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 14:36 ` Gerd Möllmann
2024-02-08 14:42 ` Mattias Engdegård
2024-02-08 15:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 17:29 ` Mattias Engdegård
2024-02-08 17:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-12 12:16 ` Mattias Engdegård [this message]
2024-02-12 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 9:05 ` Gerd Möllmann
2024-02-13 10:12 ` Mattias Engdegård
2024-02-13 12:12 ` Gerd Möllmann
2024-02-13 12:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 12:37 ` Mattias Engdegård
2024-02-14 13:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 13:21 ` Mattias Engdegård
2024-02-17 19:50 ` Mattias Engdegård
2024-02-20 10:21 ` Mattias Engdegård
2024-02-20 14:00 ` Eli Zaretskii
2024-02-20 16:11 ` Mattias Engdegård
2024-02-20 17:12 ` Eli Zaretskii
2024-02-21 12:59 ` Eli Zaretskii
2024-02-21 20:13 ` Andrea Corallo
2024-02-23 12:16 ` Mattias Engdegård
2024-02-24 9:45 ` Mattias Engdegård
2024-02-24 10:30 ` Eli Zaretskii
2024-02-24 10:53 ` Mattias Engdegård
2024-02-24 11:03 ` Eli Zaretskii
2024-02-24 17:20 ` Dmitry Gutov
2024-02-24 17:43 ` Mattias Engdegård
2024-02-24 17:48 ` Dmitry Gutov
2024-02-24 17:53 ` Mattias Engdegård
2024-02-24 18:08 ` Eli Zaretskii
2024-02-24 18:31 ` Dmitry Gutov
2024-02-24 17:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 17:14 ` Dmitry Gutov
2024-02-24 2:46 ` Dmitry Gutov
[not found] ` <20240104155642.6326FC00344@vcs2.savannah.gnu.org>
2024-01-04 18:52 ` scratch/hash-table-perf 3e9e68333ae 16/35: Remove rehash-threshold and rehash-size struct members Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=68244@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.