From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>, 68244@debbugs.gnu.org
Subject: bug#68244: hash-table improvements
Date: Sun, 21 Jan 2024 14:03:47 +0100 [thread overview]
Message-ID: <878r4iq1n0.fsf@epfl.ch> (raw)
In-Reply-To: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@gmail.com> ("Mattias Engdegård"'s message of "Thu, 4 Jan 2024 17:27:53 +0100")
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
Mattias Engdegård [2024-01-04 17:27 +0100] wrote:
> It's the hash-table's turn to be subjected to some performance tuning.
Thanks!
> The implementation has changed very little over the years and it's not
> so much a matter of a single big thing to fix as many small ones, so
> the list of changes is fairly long but ever little helps.
João, is this tiny additional straw okay for the camel's back?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Further-shrink-eglot.patch --]
[-- Type: text/x-diff, Size: 1002 bytes --]
From 359e5d5b90754373ff8a2db6431421d7838c113b Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Fri, 19 Jan 2024 13:50:29 +0100
Subject: [PATCH] Further shrink eglot--{}
Up to and including Emacs 29, :size 0 was an alias for :size 1.
Emacs 30 gained support for :size 0 hash tables (bug#68244).
* lisp/progmodes/eglot.el (eglot--{}): Define as truly zero-sized.
---
lisp/progmodes/eglot.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c5cfdd3cedd..511000927cf 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -575,7 +575,7 @@ eglot--tag-faces
(defvaralias 'eglot-{} 'eglot--{})
-(defconst eglot--{} (make-hash-table :size 1) "The empty JSON object.")
+(defconst eglot--{} (make-hash-table :size 0) "The empty JSON object.")
(defun eglot--executable-find (command &optional remote)
"Like Emacs 27's `executable-find', ignore REMOTE on Emacs 26."
--
2.43.0
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
--
Basil
next prev parent reply other threads:[~2024-01-21 13:03 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org>
[not found] ` <20240104155642.B4A99C00344@vcs2.savannah.gnu.org>
2024-01-04 17:32 ` scratch/hash-table-perf 2d28042f56a 19/35: Use non-Lisp allocation for internal hash-table vectors Dmitry Gutov
2024-01-05 10:33 ` bug#68244: hash-table improvements Mattias Engdegård
2024-01-05 15:41 ` Dmitry Gutov
2024-01-06 11:34 ` Mattias Engdegård
2024-01-06 11:51 ` Eli Zaretskii
2024-01-07 3:13 ` Dmitry Gutov
2024-01-07 5:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 15:39 ` Dmitry
2024-01-07 18:36 ` Mattias Engdegård
2024-01-07 19:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 18:26 ` Mattias Engdegård
2024-01-09 0:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 10:26 ` Mattias Engdegård
2024-01-13 20:06 ` Mattias Engdegård
2024-01-04 16:27 ` Mattias Engdegård
2024-01-04 16:39 ` Eli Zaretskii
2024-01-04 17:02 ` Mattias Engdegård
2024-01-04 17:45 ` Eli Zaretskii
2024-01-05 11:34 ` Mattias Engdegård
2024-01-05 17:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 11:46 ` Mattias Engdegård
2024-01-09 21:51 ` Stefan Kangas
2024-01-12 15:42 ` Mattias Engdegård
2024-01-14 22:08 ` Andy Moreton
2024-01-15 12:31 ` Eli Zaretskii
2024-01-15 13:26 ` Mattias Engdegård
2024-01-18 18:13 ` Mattias Engdegård
2024-01-15 20:01 ` Andy Moreton
2024-01-15 20:21 ` Eli Zaretskii
2024-01-16 21:57 ` Andy Moreton
2024-01-17 3:31 ` Eli Zaretskii
2024-01-18 20:29 ` Andy Moreton
2024-01-19 6:37 ` Eli Zaretskii
2024-01-20 20:20 ` Andy Moreton
2024-01-21 5:11 ` Eli Zaretskii
2024-01-21 13:03 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-22 9:17 ` João Távora
2024-01-22 9:18 ` João Távora
2024-01-23 9:44 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 5:25 ` Gerd Möllmann
2024-01-14 14:42 ` Mattias Engdegård
2024-01-21 12:41 ` Stefan Kangas
2024-02-08 9:46 ` Mattias Engdegård
2024-02-08 14:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 14:36 ` Gerd Möllmann
2024-02-08 14:42 ` Mattias Engdegård
2024-02-08 15:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 17:29 ` Mattias Engdegård
2024-02-08 17:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-12 12:16 ` Mattias Engdegård
2024-02-12 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 9:05 ` Gerd Möllmann
2024-02-13 10:12 ` Mattias Engdegård
2024-02-13 12:12 ` Gerd Möllmann
2024-02-13 12:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 12:37 ` Mattias Engdegård
2024-02-14 13:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 13:21 ` Mattias Engdegård
2024-02-17 19:50 ` Mattias Engdegård
2024-02-20 10:21 ` Mattias Engdegård
2024-02-20 14:00 ` Eli Zaretskii
2024-02-20 16:11 ` Mattias Engdegård
2024-02-20 17:12 ` Eli Zaretskii
2024-02-21 12:59 ` Eli Zaretskii
2024-02-21 20:13 ` Andrea Corallo
2024-02-23 12:16 ` Mattias Engdegård
2024-02-24 9:45 ` Mattias Engdegård
2024-02-24 10:30 ` Eli Zaretskii
2024-02-24 10:53 ` Mattias Engdegård
2024-02-24 11:03 ` Eli Zaretskii
2024-02-24 17:20 ` Dmitry Gutov
2024-02-24 17:43 ` Mattias Engdegård
2024-02-24 17:48 ` Dmitry Gutov
2024-02-24 17:53 ` Mattias Engdegård
2024-02-24 18:08 ` Eli Zaretskii
2024-02-24 18:31 ` Dmitry Gutov
2024-02-24 17:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 17:14 ` Dmitry Gutov
2024-02-24 2:46 ` Dmitry Gutov
[not found] ` <20240104155642.6326FC00344@vcs2.savannah.gnu.org>
2024-01-04 18:52 ` scratch/hash-table-perf 3e9e68333ae 16/35: Remove rehash-threshold and rehash-size struct members Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r4iq1n0.fsf@epfl.ch \
--to=bug-gnu-emacs@gnu.org \
--cc=68244@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=joaotavora@gmail.com \
--cc=mattias.engdegard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.