all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liu Hui <liuhui1610@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62413@debbugs.gnu.org
Subject: bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position
Date: Thu, 30 Mar 2023 10:49:39 +0800	[thread overview]
Message-ID: <CAOQTW-OiHvB0CC9qNmv7yG+rD+SRrscxWPu=eThe5hn8=NOVMg@mail.gmail.com> (raw)
In-Reply-To: <83cz4t84mv.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> 于2023年3月28日周二 20:03写道:
>
> > From: Liu Hui <liuhui1610@gmail.com>
> > Date: Tue, 28 Mar 2023 13:56:05 +0800
> > Cc: 62413@debbugs.gnu.org
> >
> > Eli Zaretskii <eliz@gnu.org> 于2023年3月26日周日 13:20写道:
> >
> > > Ugh!  This feature was not thought out well enough when it was
> > > introduced: if the user changes the value half-way through a session,
> > > the history will record visited files twice, under 2 different
> > > file-name formats and with different places recorded.  I think
> > > changing the value of save-place-abbreviate-file-names should rewrite
> > > the entire alist in the selected format.
> >
> > I agree that it is better to avoid mixed file name formats, and then
> > save-place-find-file-hook can be fixed simply. The difficult part is
> > how to rewrite save-place-alist automatically.
>
> Isn't it just a matter of going through the list and calling
> abbreviate-file-name on each file name there?

The conversion itself is easy. But users can change the value of
save-place-abbreviate-file-names anytime. To make sure the list is
always consistent with save-place-abbreviate-file-names, I think an
internal variable is needed to record the old value. If they are
different when save-place-to-alist is called, we rewrite the list. Is
it OK?





  reply	other threads:[~2023-03-30  2:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  2:19 bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position Liu Hui
2023-03-25 11:52 ` Eli Zaretskii
2023-03-25 14:14   ` Liu Hui
2023-03-25 14:17     ` Eli Zaretskii
2023-03-26  1:26       ` Liu Hui
2023-03-26  5:20         ` Eli Zaretskii
2023-03-28  5:56           ` Liu Hui
2023-03-28 12:03             ` Eli Zaretskii
2023-03-30  2:49               ` Liu Hui [this message]
2023-03-30  5:34                 ` Eli Zaretskii
2023-04-03  1:02                   ` Liu Hui
2023-04-03  2:45                     ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-04  1:37                       ` Liu Hui
2023-04-06 10:27                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQTW-OiHvB0CC9qNmv7yG+rD+SRrscxWPu=eThe5hn8=NOVMg@mail.gmail.com' \
    --to=liuhui1610@gmail.com \
    --cc=62413@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.