From: Liu Hui <liuhui1610@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62413@debbugs.gnu.org
Subject: bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position
Date: Sat, 25 Mar 2023 22:14:02 +0800 [thread overview]
Message-ID: <CAOQTW-Ni_Z-W+=MA+PCYGmfr18ic+=YBKwxiZH0cKyg2YPorgg@mail.gmail.com> (raw)
In-Reply-To: <83tty9caku.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
在 2023/3/25 19:52, Eli Zaretskii 写道:
>> --- a/lisp/saveplace.el
>> +++ b/lisp/saveplace.el
>> @@ -353,8 +353,11 @@ save-place-find-file-hook
>> "Function added to `find-file-hook' by `save-place-mode'.
>> It runs the hook `save-place-after-find-file-hook'."
>> (or save-place-loaded (save-place-load-alist-from-file))
>> - (let ((cell (assoc buffer-file-name save-place-alist)))
>> + (let* ((item (if (and (stringp buffer-file-name)
>> + save-place-abbreviate-file-names)
>> + (abbreviate-file-name buffer-file-name)
>> + buffer-file-name))
>> + (cell (assoc item save-place-alist)))
>
> Wouldn't it be best to always test for abbreviated file name if the
> full file name fails to match? E.g., it could be that the user turned
> on save-place-abbreviate-file-names for a while, then turned it off
> (or vice versa), thus causing mixed file names in the saved history.
> It would also make the code simpler, I think.
I agree that it is better to consider mixed file names. Please see the
updated patch.
[-- Attachment #2: 0001-Restore-positions-for-abbreviated-file-names-in-save.patch --]
[-- Type: application/x-patch, Size: 1427 bytes --]
next prev parent reply other threads:[~2023-03-25 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 2:19 bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position Liu Hui
2023-03-25 11:52 ` Eli Zaretskii
2023-03-25 14:14 ` Liu Hui [this message]
2023-03-25 14:17 ` Eli Zaretskii
2023-03-26 1:26 ` Liu Hui
2023-03-26 5:20 ` Eli Zaretskii
2023-03-28 5:56 ` Liu Hui
2023-03-28 12:03 ` Eli Zaretskii
2023-03-30 2:49 ` Liu Hui
2023-03-30 5:34 ` Eli Zaretskii
2023-04-03 1:02 ` Liu Hui
2023-04-03 2:45 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-04 1:37 ` Liu Hui
2023-04-06 10:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQTW-Ni_Z-W+=MA+PCYGmfr18ic+=YBKwxiZH0cKyg2YPorgg@mail.gmail.com' \
--to=liuhui1610@gmail.com \
--cc=62413@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.