Re: fix for bug 10994 breaks ido customizations in major way

[Le Wang <l26wang@gmail.com>]

On Wed, May 8, 2013 at 8:04 AM, Leo Liu <sdl.web@gmail.com> wrote:
> On 2013-05-08 03:53 +0800, Óscar Fuentes wrote:
>> You are inconveniencing a real (and quite useulf, IMHO) application because
>> some imaginary, unspecified application?
>>
>> And, have you considered that there are users who don't see any coloring
>> on Emacs? (because the limitations of their terminals, or because they
>> are using voice-to-speach systems, or simply because they regard
>> anything but raw text as distracting noise.)
>
> When I was coming up with a fix for bug#10994 I have already considered
> removing duplicates as an option. But I rejected it on the basis of that
> being the responsibility of the caller

`completing-read' already removes duplicates.  `ido-completing-read'
should just follow its lead.

> and do not want to take that away
> from the programmers.

I want to reiterate this was never "given" to programmers in a
released version of ido.

> Anyway, I'll see if I can bake these two options in.

Baking these two in is not necessary at all!  Think about Óscar
Fuentes's scenario of someone being completely color blind.  Why are
we going out of our way to make the UI bad for these people?


--
Le