From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720)
Date: Thu, 4 May 2023 01:50:17 +0100 [thread overview]
Message-ID: <CALDnm52LhtTyf0_kAaA4gaFbO_Ar9ChkQrgGdcyhAWk-Ejt=9g@mail.gmail.com> (raw)
In-Reply-To: <6a09451b-88dd-ff00-2bdc-cb34d457adef@gutov.dev>
On Thu, May 4, 2023 at 12:39 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
>
> On 04/05/2023 02:31, João Távora wrote:
> > On Wed, May 3, 2023 at 11:48 PM Dmitry Gutov<dmitry@gutov.dev> wrote:
> >> On 28/04/2023 03:35, João Távora wrote:
> >>> On Fri, Apr 28, 2023 at 12:53 AM Dmitry Gutov<dmitry@gutov.dev> wrote:
> >>>> Hi!
> >>>>
> >>>> On 28/04/2023 02:39, João Távora wrote:
> >>>>> * lisp/progmodes/eglot.el (eglot-update): New command.
> >>>> Should it be called eglot-upgrade now as well?
> >>> No objection, don't feel strongly about it. If you want to
> >>> change it, go ahead, but remember to change the manual as
> >>> well.
> >> Ok, I did the rename.
> > Hmmm, unfortunate. I thought you had abandoned the idea,
> > as you didn't reply to that part specifically.
>
> I did reply, with a question.
Right, but I had said "I don't feel strongly about it",
meaning I don't care either way. So i didn't reply because
I though I would be repeating myself.
Anyway, I would rather not have people that have already gotten 1.15 and
using it (not many) seeing eglot-update change to eglot-upgrade.
By 1.20 noone will remember, but I think we should at least add a
compatibility alias (eglot-upgrade being the advertised one, and keep
eglot-update for 3/4 versions).
> Up to you either way.
Please add the compatibility alias, if you can.
> >> Two more things:
> >>
> >> - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of
> >> eglot-completion-at-point which has been there for a few years. Was that
> >> intentional? Didn't look like it.
> > Not intentional no. Well, at least not for that commit.
> > Not pretty, but I wouldn't worry about it.
>
> So it's not a breakage? Okay then.
No, it was actually intended (not for that commit of course).
>
> >> - Consider the issue that I brought up in
> >> https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot
> >> package-archive-contents)). I'm not sure there's even a guarantee that
> >> the available versions are sorted, but even if they are obeying
> >> package-archive-priorities seems like a good idea. Though I can
> >> understand if it's not your first priority in this command.
> > Is this a problem that can affect the Eglot package
> > specifically? In which conditions?
>
> The user customizes priorities for GNU ELPA and GNU-devel, and 'M-x
> eglot-upgrade' upgrades to a version from the archive with lower
> priority. Something like that.
Too late to think about what the right thing to do is. What I
think i'll do eventually is add a confirmation prompt for
interactive calls to eglot-update.
João
next prev parent reply other threads:[~2023-05-04 0:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org>
[not found] ` <20230427233949.44D31C22A13@vcs2.savannah.gnu.org>
2023-04-27 23:52 ` emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Dmitry Gutov
2023-04-28 0:35 ` João Távora
2023-04-28 0:40 ` Dmitry Gutov
2023-05-03 22:48 ` Dmitry Gutov
2023-05-03 23:31 ` João Távora
2023-05-03 23:39 ` Dmitry Gutov
2023-05-04 0:50 ` João Távora [this message]
2023-05-04 0:56 ` Dmitry
2023-05-04 1:09 ` João Távora
2023-05-04 9:05 ` Dmitry Gutov
2023-05-05 14:01 ` João Távora
2023-05-05 15:06 ` Dmitry Gutov
2023-04-28 4:37 ` Eli Zaretskii
2023-04-28 14:25 ` Philip Kaludercic
2023-04-28 15:30 ` Dmitry Gutov
2023-04-28 18:12 ` Philip Kaludercic
2023-04-29 0:52 ` Dmitry Gutov
2023-04-29 6:45 ` Eli Zaretskii
2023-04-29 10:01 ` Dmitry
2023-04-29 10:13 ` Philip Kaludercic
2023-04-29 11:51 ` Dmitry
2023-04-29 10:34 ` Eli Zaretskii
2023-04-29 9:08 ` Philip Kaludercic
2023-04-29 9:40 ` Eli Zaretskii
2023-04-29 9:54 ` Dmitry
2023-04-29 10:15 ` Philip Kaludercic
2023-04-29 12:52 ` João Távora
2023-04-29 13:10 ` Po Lu
2023-04-30 12:12 ` Philip Kaludercic
2023-04-30 17:43 ` Michael Albinus
2023-05-01 2:09 ` João Távora
2023-05-01 7:34 ` Philip Kaludercic
2023-05-02 7:56 ` Robert Pluim
2023-05-05 5:13 ` Philip Kaludercic
2023-05-05 6:23 ` Robert Pluim
2023-05-02 20:35 ` João Távora
2023-04-29 6:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52LhtTyf0_kAaA4gaFbO_Ar9ChkQrgGdcyhAWk-Ejt=9g@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.