From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Date: Thu, 4 May 2023 01:50:17 +0100 Message-ID: References: <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org> <20230427233949.44D31C22A13@vcs2.savannah.gnu.org> <20f53b0a-d6ff-8ec0-2f8c-e0e22b2d49dc@gutov.dev> <6a09451b-88dd-ff00-2bdc-cb34d457adef@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19896"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 02:51:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puNBp-0004xM-I7 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 02:51:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puNB3-0001Nx-S4; Wed, 03 May 2023 20:50:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puNB2-0001HS-5t for emacs-devel@gnu.org; Wed, 03 May 2023 20:50:32 -0400 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puNB0-0003jQ-8U for emacs-devel@gnu.org; Wed, 03 May 2023 20:50:31 -0400 Original-Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-38dfbbfe474so1570434b6e.0 for ; Wed, 03 May 2023 17:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683161428; x=1685753428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oXjY6FomUvn//9ErYzQ8mnDjMrgqCEXYtAs1O0AgsOM=; b=pv/WLDBxLhYSrX9PZ2V+2wUvhQ2XuEJlqrZsFNZFjYZ0GTXCte/koQmDsikHbpofnM Vs5neCDzHBXXFwSScMDT6ky5uzfPPQVgIpjb2xy1Eq8jtin8skhGw7D/xUDOl9UF8A8O zva2VXJUke9CY/O6mrnBYWdKR3SUMC4KBI5cHy3ryBIQck7Np5xxnsVqwbcyvFSYcBc1 4yASbiscDYPP7wLyCLDn01MPNLqK1Pg9TCddcaW0GonFdj7nNZArFi97MTu9T9ZDMcrk fRB07bk/u3h3Mf5Ca4aMIp+Rm88BmME2cJ29xqZaFLijYtgrHOBTcYG8hUTktSelEN75 w+zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683161428; x=1685753428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oXjY6FomUvn//9ErYzQ8mnDjMrgqCEXYtAs1O0AgsOM=; b=IwpMUKIXVJS4wuAGPIRsWHLJQNFSbDEt8l4t2CdOqHdgG7xskvn6R7ueopiS4CbW4c kNtIza/p1uA8QhGIgNtTrrPZHtEsJrG49mRpAaCyyRV+v3K/pfDlcBFhbbAKGOAsItg5 XIaquw3qFoocUAWr3HIujEGdmrIwpr3AaIxm40Tet+Ge6tjuiWh9I142TQ74AN0EF42T FUzhEMRZuUfu9I2H/9C+bMVFHC2GD334szDkwDD+UfT8hfMLgi5mbPEMNhS2QZoj7Tev fDOU1VgUwpk4dZjnXG5rWsPz9j4kyvsPMddtY6ji9s0Gf+QtHNZBE/FLaSjCQwfjJX8y GFcA== X-Gm-Message-State: AC+VfDz6FLadFhc2Ff77YaoZaj3Cx5zBt2VCOGKv5fozN5VGAWGlNBC3 9VELqP4nK+QFbFts6NmT6M/hondPW1/+kPFsses= X-Google-Smtp-Source: ACHHUZ7aDOGyWunbMOpJcuD3yEZXVnjQandiMUMNZeMVdxpVivnYklXTXHN/h8Xy5qRIfJiHmXxVnhzOYFkgG0AUNw4= X-Received: by 2002:a05:6808:210f:b0:392:116a:cce7 with SMTP id r15-20020a056808210f00b00392116acce7mr920488oiw.33.1683161428598; Wed, 03 May 2023 17:50:28 -0700 (PDT) In-Reply-To: <6a09451b-88dd-ff00-2bdc-cb34d457adef@gutov.dev> Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305807 Archived-At: On Thu, May 4, 2023 at 12:39=E2=80=AFAM Dmitry Gutov wro= te: > > On 04/05/2023 02:31, Jo=C3=A3o T=C3=A1vora wrote: > > On Wed, May 3, 2023 at 11:48=E2=80=AFPM Dmitry Gutov = wrote: > >> On 28/04/2023 03:35, Jo=C3=A3o T=C3=A1vora wrote: > >>> On Fri, Apr 28, 2023 at 12:53=E2=80=AFAM Dmitry Gutov wrote: > >>>> Hi! > >>>> > >>>> On 28/04/2023 02:39, Jo=C3=A3o T=C3=A1vora wrote: > >>>>> * lisp/progmodes/eglot.el (eglot-update): New command. > >>>> Should it be called eglot-upgrade now as well? > >>> No objection, don't feel strongly about it. If you want to > >>> change it, go ahead, but remember to change the manual as > >>> well. > >> Ok, I did the rename. > > Hmmm, unfortunate. I thought you had abandoned the idea, > > as you didn't reply to that part specifically. > > I did reply, with a question. Right, but I had said "I don't feel strongly about it", meaning I don't care either way. So i didn't reply because I though I would be repeating myself. Anyway, I would rather not have people that have already gotten 1.15 and using it (not many) seeing eglot-update change to eglot-upgrade. By 1.20 noone will remember, but I think we should at least add a compatibility alias (eglot-upgrade being the advertised one, and keep eglot-update for 3/4 versions). > Up to you either way. Please add the compatibility alias, if you can. > >> Two more things: > >> > >> - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of > >> eglot-completion-at-point which has been there for a few years. Was th= at > >> intentional? Didn't look like it. > > Not intentional no. Well, at least not for that commit. > > Not pretty, but I wouldn't worry about it. > > So it's not a breakage? Okay then. No, it was actually intended (not for that commit of course). > > >> - Consider the issue that I brought up in > >> https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot > >> package-archive-contents)). I'm not sure there's even a guarantee that > >> the available versions are sorted, but even if they are obeying > >> package-archive-priorities seems like a good idea. Though I can > >> understand if it's not your first priority in this command. > > Is this a problem that can affect the Eglot package > > specifically? In which conditions? > > The user customizes priorities for GNU ELPA and GNU-devel, and 'M-x > eglot-upgrade' upgrades to a version from the archive with lower > priority. Something like that. Too late to think about what the right thing to do is. What I think i'll do eventually is add a confirmation prompt for interactive calls to eglot-update. Jo=C3=A3o