bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc

["João Távora" <joaotavora@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Sat, Apr 8, 2023, 22:04 Mekeor Melire <mekeor@posteo.de> wrote:

> 2023-04-08 20:47 joaotavora@gmail.com:
>
> > Mekeor Melire <mekeor@posteo.de> writes:
> >
> > > The main issue is that Eglot won't show the
> > > "SignatureInformation"'s "documentation" field if it is of
> > > type MarkupContent.
> >
> > OK I see it, I understand it, and I've done some changes to
> > master. Please have a look at commit
> > 685435cb52eaa6f61b7088398f1f53e69d76e63e.
>
> Thank you! That commit indeed makes Eglot show
> "SignatureInformation"'s "documentation" field even if it's of
> type MarkupContent. So it solves this main issue.
>
> Unfortunately, that commit causes Eglot to not show the
> "ParameterInformation"'s "documenation" field. I propose to show
> both the SigInfo- and the ParamInfo-documentation, whenever
> possible. (To be more precise: First, the SigInfo-doc should be
> shown, if non-nil. Then, the ParamInfo-doc should be shown, if
> non-nil.) What do you think?
>

Ok, i took it out, because I didn't find any server that used it. Pylsp
uses it, but the doc is always the empty string. Does your TS server use
it? Did you get around to providing the event log i asked for?

Would you like to have an audio-call to talk about the problems
> related to `eglot--sig-info'? I think it would be much more
> efficient than email.
>

I'm on GMT time, but I don't know when I'll be available. Mail me off-list.

João

[-- Attachment #2: Type: text/html, Size: 2455 bytes --]