From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc Date: Sat, 8 Apr 2023 22:12:31 +0100 Message-ID: References: <875yaanfuv.fsf@posteo.de> <87fs9bmg1j.fsf@posteo.de> <87cz4egnqa.fsf@gmail.com> <87bkjym6ic.fsf@posteo.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004710c605f8d99a7a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34301"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62687@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 23:13:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plFs1-0008kG-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 23:13:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plFrs-0002UJ-Az; Sat, 08 Apr 2023 17:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plFrr-0002Tn-0y for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plFrq-0002Mr-Oi for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plFrq-0005B3-Ko for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62687 X-GNU-PR-Package: emacs Original-Received: via spool by 62687-submit@debbugs.gnu.org id=B62687.168098837219863 (code B ref 62687); Sat, 08 Apr 2023 21:13:02 +0000 Original-Received: (at 62687) by debbugs.gnu.org; 8 Apr 2023 21:12:52 +0000 Original-Received: from localhost ([127.0.0.1]:59726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plFrf-0005AH-UP for submit@debbugs.gnu.org; Sat, 08 Apr 2023 17:12:52 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:38431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plFrd-0005A1-4y for 62687@debbugs.gnu.org; Sat, 08 Apr 2023 17:12:49 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id q5-20020a056830232500b006a11eb19f8eso163907otg.5 for <62687@debbugs.gnu.org>; Sat, 08 Apr 2023 14:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680988363; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/erSe4hn9xzNBE6aBk3HRP0PQJQ6LPrU1RD/aKIMfSA=; b=UMDA4NaLrjAtnjuUe2ajlL9VarScHNLk3jByistcoXjnezJfT/A0vBXjsNqVTGrjEl rhmRjpyf8afjczGPEZjoRfee6LV/l2kWHv7ZgT0i1Zla+bqigkToypo28Iu70P8MrJan 11Sa3ohMtI9IUAVM7hx82dDs5NvvasZsayR6QfecoktpnGYko87lDCAFy5vudemkqchw nYmfAXGZKaOKT5UfHjuKEjGuMGlP13aNFB2stGA0dezYpluAKbmmF9b0UgdzDoIn0366 9rAk/6fhYG8S+4NyWCsNz7pDvVJB/moXGM+UXHlbkGIfq2VkVGtLYD8rxw0V0OcAzZLJ 1fTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680988363; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/erSe4hn9xzNBE6aBk3HRP0PQJQ6LPrU1RD/aKIMfSA=; b=h1Y2JUcvWcM4BTsYbiJOHk+ONTMyUYc+rVQMP3mgSAMN1LzHqmGJu++q42BNw/O19g MV0BHDCd0Eencm+ohg70WkrRRM52xpLXUDWXg2Xa/aWXgYp829aaZkO2W+8uGO6TkYbG +VNvbH4iYphM2EVZyHijOqKQ4FXqAQk33ZK34+usiLZG4EEmwIo3cXGKwxwsAxeXPqJB /+0LGF0infcTx8DRrtp3v93dWl1c+uYia4H0Lw9scDZh4wP7bCSIMoJbARyT03yy+5X+ WrRIKkvTi95M4robpRd3OAJAAHeEYb0eEkT7+00I/uKNZNAHTUNyMCaJHS+IPoBYS3kx rLxw== X-Gm-Message-State: AAQBX9dIAwKXlYr5an+AKpOw7fiO880PqwCcSRnWJxA5k2rIW3SdowyG 3B5mSeScMg9ca2iRzyRHzfKb7Xf9+5jO+0cnyx4= X-Google-Smtp-Source: AKy350aSh8INN+X/BIxch+kUvqMHOAnui5JfjQs3nGLHM6YppPoI2/2l2MAxo7SvGvqxy+sq4R+DoFklklLbjdLwcww= X-Received: by 2002:a05:6830:1641:b0:69f:262:c524 with SMTP id h1-20020a056830164100b0069f0262c524mr678009otr.4.1680988363492; Sat, 08 Apr 2023 14:12:43 -0700 (PDT) In-Reply-To: <87bkjym6ic.fsf@posteo.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259497 Archived-At: --0000000000004710c605f8d99a7a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Apr 8, 2023, 22:04 Mekeor Melire wrote: > 2023-04-08 20:47 joaotavora@gmail.com: > > > Mekeor Melire writes: > > > > > The main issue is that Eglot won't show the > > > "SignatureInformation"'s "documentation" field if it is of > > > type MarkupContent. > > > > OK I see it, I understand it, and I've done some changes to > > master. Please have a look at commit > > 685435cb52eaa6f61b7088398f1f53e69d76e63e. > > Thank you! That commit indeed makes Eglot show > "SignatureInformation"'s "documentation" field even if it's of > type MarkupContent. So it solves this main issue. > > Unfortunately, that commit causes Eglot to not show the > "ParameterInformation"'s "documenation" field. I propose to show > both the SigInfo- and the ParamInfo-documentation, whenever > possible. (To be more precise: First, the SigInfo-doc should be > shown, if non-nil. Then, the ParamInfo-doc should be shown, if > non-nil.) What do you think? > Ok, i took it out, because I didn't find any server that used it. Pylsp uses it, but the doc is always the empty string. Does your TS server use it? Did you get around to providing the event log i asked for? Would you like to have an audio-call to talk about the problems > related to `eglot--sig-info'? I think it would be much more > efficient than email. > I'm on GMT time, but I don't know when I'll be available. Mail me off-list. Jo=C3=A3o --0000000000004710c605f8d99a7a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Apr 8, 2023, 22:04 Mekeor Melire <mekeor@posteo.de> wrote:
2023-04-08 20:47 joaotavora@gmail.com:

> Mekeor Melire <mekeor@posteo.de> writes:
>
> > The main issue is that Eglot won't show the
> > "SignatureInformation"'s "documentation" = field if it is of
> > type MarkupContent.
>
> OK I see it, I understand it, and I've done some changes to
> master. Please have a look at commit
> 685435cb52eaa6f61b7088398f1f53e69d76e63e.

Thank you! That commit indeed makes Eglot show
"SignatureInformation"'s "documentation" field even= if it's of
type MarkupContent. So it solves this main issue.

Unfortunately, that commit causes Eglot to not show the
"ParameterInformation"'s "documenation" field. I pr= opose to show
both the SigInfo- and the ParamInfo-documentation, whenever
possible. (To be more precise: First, the SigInfo-doc should be
shown, if non-nil. Then, the ParamInfo-doc should be shown, if
non-nil.) What do you think?
=
Ok, i took it out, because I didn't find an= y server that used it. Pylsp uses it, but the doc is always the empty strin= g. Does your TS server use it? Did you get around to providing the event lo= g i asked for?

Would you like to have an audio-call to talk about the problems
related to `eglot--sig-info'? I think it would be much more
efficient than email.

I'm on GMT time, but I don't know when I'l= l be available. Mail me off-list.

Jo=C3=A3o
--0000000000004710c605f8d99a7a--