From: "João Távora" <joaotavora@gmail.com>
To: Psionic K <psionik@positron.solutions>
Cc: 68568@debbugs.gnu.org, Jonas Bernoulli <jonas@bernoul.li>
Subject: bug#68568: transient.el interns potentially enormous symbols as commands
Date: Sun, 21 Jan 2024 08:10:33 +0000 [thread overview]
Message-ID: <CALDnm51o2i=LitR3tmyZ5xf917i-D+pkRLLmdPESoN2isLhNuA@mail.gmail.com> (raw)
In-Reply-To: <CADQMGAT638JPYQAkOOWJvCwjYqOi_JZE7jQ9LDjdXTc0H3xUVA@mail.gmail.com>
On Sun, Jan 21, 2024 at 7:29 AM Psionic K <psionik@positron.solutions> wrote:
>
> > long descriptions of infix commands
>
> That's a user choice btw. Anyone can make long symbols through a
Not sure what you mean by "user". I'm a "user" of GPTel, but
I didn't make those long description. GPTel uses those descriptions
and, I think, reasonably.
> variety of means that are out of control of any package.
Sure, but that package shouldn't gratuitously have that choice
(questionable as it may be -- I think it's not) wreak havoc everywhere
else in Emacs. This is what happens with transient's interning
of such symbols
> definitely take alternative routes to avoid creating long symbols in
> transient.
I'd rather not bother transient-using packages with code complications.
GPTel's interface is fine as it is.
> 200 and how many instances?
About 8 or 9, all transient's. Doesn't matter because the greediness of the
flex matching algorithm, which was designed for short symbols,
eventually picks up on a pattern which is highly likely to appear in
the extremely long tail of the enormous symbol
So my usual searches like M-x vc SPC always where I expect to see
"vc" commands turn up some silly transient command, useless and
unwanted in that context.
> > transient.el works just fine with make-symbol instead of intern.
>
> It sounds like you have a patch ready for the upstream. Bon appetit:
> https://github.com/magit/transient
I take it you still can't think of a good reason why those symbols
should be internet. OK. Created a PR. I hope this gets fixed
quickly over here at the downstream. This is not something easy
to monkey-patch around.
João
next prev parent reply other threads:[~2024-01-21 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 11:50 bug#68568: transient.el interns potentially enormous symbols as commands João Távora
2024-01-21 4:27 ` Psionic K
2024-01-21 7:15 ` João Távora
2024-01-21 7:29 ` Psionic K
2024-01-21 8:10 ` João Távora [this message]
2024-01-21 8:26 ` Psionic K
2024-01-21 8:33 ` João Távora
2024-01-27 9:15 ` Eli Zaretskii
2024-01-27 18:18 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-01 10:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51o2i=LitR3tmyZ5xf917i-D+pkRLLmdPESoN2isLhNuA@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=68568@debbugs.gnu.org \
--cc=jonas@bernoul.li \
--cc=psionik@positron.solutions \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.