From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#68568: transient.el interns potentially enormous symbols as commands Date: Sun, 21 Jan 2024 08:10:33 +0000 Message-ID: References: <87r0ibrwbd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19328"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68568@debbugs.gnu.org, Jonas Bernoulli To: Psionic K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 21 09:11:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRSvP-0004tO-4O for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jan 2024 09:11:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRSuz-0006IP-ES; Sun, 21 Jan 2024 03:11:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRSux-0006IB-86 for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:10:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRSux-0003Ff-05 for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:10:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRSv0-00071e-3O for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jan 2024 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68568 X-GNU-PR-Package: emacs Original-Received: via spool by 68568-submit@debbugs.gnu.org id=B68568.170582465626994 (code B ref 68568); Sun, 21 Jan 2024 08:11:02 +0000 Original-Received: (at 68568) by debbugs.gnu.org; 21 Jan 2024 08:10:56 +0000 Original-Received: from localhost ([127.0.0.1]:36491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRSuu-00071K-01 for submit@debbugs.gnu.org; Sun, 21 Jan 2024 03:10:56 -0500 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:47255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRSup-000711-Jz for 68568@debbugs.gnu.org; Sun, 21 Jan 2024 03:10:54 -0500 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50e72e3d435so1968000e87.2 for <68568@debbugs.gnu.org>; Sun, 21 Jan 2024 00:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705824642; x=1706429442; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gr75J8qnS1kfeRpL4VGA8Z9pZvnxjuKa4JseAYFYX5Y=; b=N5/iogZf18EXPSUsBQIK1f+ZLWXL4UmUjaKs0KUN1Ks62CdsqmDG6RObKKr7wgqehz hnfSgYn2smEaObYpI1xaGUEx99TJ21vqEpK0YETzRZEqerkJX0YgvsZY6u6Wos7hIn45 SXXGCHZf17M3Zq4FpM7fKsVhlnkTFdWMUJrsH6VBxXda8S10FNqc9cGVAW9AZRHjlh9B qpzvjmc3l49IvP0BqXj01TfhOXjQSoUujzJNWQT6n0o1C9FqKVdEY4qLgkemoZHbM0c5 KMSfXEADm+mGUP9jplWWFBV9RFKOs4xt5mUxcuKbWkrvbyy/cqd94MarVEijK+r35YgX Mysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705824642; x=1706429442; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gr75J8qnS1kfeRpL4VGA8Z9pZvnxjuKa4JseAYFYX5Y=; b=gAJfAYSSdBea7nutiPANZ5xB36uW2FTiKDL2VHmBRqMstBoIZ5pujVR5gLDKv2m7up vSHfmFMk3Uwsx6NDNYb0QFxnD9cs1EEGeO4Es73+2M+BzRyOBaq6zA/5RQ6D0hDGMDi+ 6ucA8zaW7biSTD3o5ooi0lAFIt5U6U+ak7APjcJ7cl+fz73CPcN4TYqrF2qESxwmQz/t eAKYXQXkOHcYOUQb43vh7aFlpu3GiD2eES9FWGuQnFJaYgemT4GDCaLT7tgxipK0hKaD 5XHKcgakiS56EtiePvO3sNLPDwYvH4LKeB7hBAOG91hsFezucO+rod2Oz5An9nRyeMuE x1tw== X-Gm-Message-State: AOJu0YyCTDferQF/GA/K292x10wzwUEBui+/mP4K3+Yp2aLmVpCzq/Eg t+aFS0+cZ56AhD37/ia9nJKnGsgKHyAS0yzgxE06ovSWzRnP7nmLn6bgHulIGju5lkR2Uw5QqfE av/hH+MeD2FzArJAVc1phqyfiuxhhP4/V X-Google-Smtp-Source: AGHT+IFcQUY/snfXNxdBAJMIim6fZd/gbLObL/SLTDmH45GarjshmO2kn/mgxop0TyY7RMgdHfNrQT3QS1Riz5aXdHM= X-Received: by 2002:a05:6512:2112:b0:50e:3fbb:e5e4 with SMTP id q18-20020a056512211200b0050e3fbbe5e4mr555888lfr.164.1705824641942; Sun, 21 Jan 2024 00:10:41 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278653 Archived-At: On Sun, Jan 21, 2024 at 7:29=E2=80=AFAM Psionic K wrote: > > > long descriptions of infix commands > > That's a user choice btw. Anyone can make long symbols through a Not sure what you mean by "user". I'm a "user" of GPTel, but I didn't make those long description. GPTel uses those descriptions and, I think, reasonably. > variety of means that are out of control of any package. Sure, but that package shouldn't gratuitously have that choice (questionable as it may be -- I think it's not) wreak havoc everywhere else in Emacs. This is what happens with transient's interning of such symbols > definitely take alternative routes to avoid creating long symbols in > transient. I'd rather not bother transient-using packages with code complications. GPTel's interface is fine as it is. > 200 and how many instances? About 8 or 9, all transient's. Doesn't matter because the greediness of th= e flex matching algorithm, which was designed for short symbols, eventually picks up on a pattern which is highly likely to appear in the extremely long tail of the enormous symbol So my usual searches like M-x vc SPC always where I expect to see "vc" commands turn up some silly transient command, useless and unwanted in that context. > > transient.el works just fine with make-symbol instead of intern. > > It sounds like you have a patch ready for the upstream. Bon appetit: > https://github.com/magit/transient I take it you still can't think of a good reason why those symbols should be internet. OK. Created a PR. I hope this gets fixed quickly over here at the downstream. This is not something easy to monkey-patch around. Jo=C3=A3o