bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

[Robert Burks]

[-- Attachment #1.1: Type: text/plain, Size: 245 bytes --]

With a non-flymake window selected, hovering over the flymake line lighter
of an inactive window generates errors.  This also occurs where the
indicators are shown in describe mode help.

The attached patch corrects this issue.

Robert A. Burks

[-- Attachment #1.2: Type: text/html, Size: 335 bytes --]

[-- Attachment #2: 0001-Fix-flymake-lighter-tool-tip-from-generating-errors.patch --]
[-- Type: text/x-patch, Size: 2045 bytes --]

From 7d9baf7a782b3f569c51c3533798df6cc00b1acd Mon Sep 17 00:00:00 2001
From: "Robert A. Burks" <rburksdev@gmail.com>
Date: Fri, 16 Feb 2024 18:17:52 -0500
Subject: [PATCH] Fix flymake lighter tool-tip from generating errors

Flymake tool-tip was generating errors on mouse over of
mode-line lighter on inactive windows and on the minor mode
indicator in the describe-mode Help page.
* lisp/progmodes/flymake.el (flymake--mode-line-title):
help-echo now uses buffer local state and makes null check.
---
 lisp/progmodes/flymake.el | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index bb062753d39..23c6d9cf85d 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1401,13 +1401,19 @@ flymake--mode-line-title
     ,flymake-mode-line-lighter
     mouse-face mode-line-highlight
     help-echo
-    ,(lambda (&rest _)
-       (concat
-        (format "%s known backends\n" (hash-table-count flymake--state))
-        (format "%s running\n" (length (flymake-running-backends)))
-        (format "%s disabled\n" (length (flymake-disabled-backends)))
-        "mouse-1: Display minor mode menu\n"
-        "mouse-2: Show help for minor mode"))
+    ,(lambda (w &rest _)
+       (with-current-buffer (window-buffer w)
+         ;; Mouse can activate tool-tip without window being active.
+         ;; `flymake--state' is buffer local and is null when line
+         ;; lighter appears in *Help* `describe-mode'.
+         (concat
+          (unless (null flymake--state)
+            (concat
+             (format "%s known backends\n"  (hash-table-count flymake--state))
+             (format "%s running\n" (length (flymake-running-backends)))
+             (format "%s disabled\n" (length (flymake-disabled-backends)))))
+          "mouse-1: Display minor mode menu\n"
+          "mouse-2: Show help for minor mode")))
     keymap
     ,(let ((map (make-sparse-keymap)))
        (define-key map [mode-line down-mouse-1]
-- 
2.34.1

bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

[Eli Zaretskii]

> From: Robert Burks <rburksdev@gmail.com>
> Date: Fri, 16 Feb 2024 19:07:12 -0500
> 
> With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
> errors.  This also occurs where the indicators are shown in describe mode help.  
> 
> The attached patch corrects this issue.

Thanks.

João, could you please review the patch?

bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

[João Távora]

On Thu, Feb 22, 2024 at 1:24 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Robert Burks <rburksdev@gmail.com>
> > Date: Fri, 16 Feb 2024 19:07:12 -0500
> >
> > With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
> > errors.  This also occurs where the indicators are shown in describe mode help.
> >
> > The attached patch corrects this issue.
>
> Thanks.
>
> João, could you please review the patch?

No, but I'm copying Spencer Baugh, who has expressed interest in becoming
Flymake maintainer (and has my full endorsement, though I haven't worked
out the bureaucracy, if there is any)

João

bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

[Spencer Baugh]

João Távora <joaotavora@gmail.com> writes:
> On Thu, Feb 22, 2024 at 1:24 PM Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> > From: Robert Burks <rburksdev@gmail.com>
>> > Date: Fri, 16 Feb 2024 19:07:12 -0500
>> >
>> > With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
>> > errors.  This also occurs where the indicators are shown in describe mode help.
>> >
>> > The attached patch corrects this issue.
>>
>> Thanks.
>>
>> João, could you please review the patch?
>
> No, but I'm copying Spencer Baugh, who has expressed interest in becoming
> Flymake maintainer (and has my full endorsement, though I haven't worked
> out the bureaucracy, if there is any)
>
> João

The patch seems correct, if someone with commit access could please
apply it.

bug#69248: [PATCH] Fix flymake lighter tool-tip from generating errors

[Eli Zaretskii]

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  69248@debbugs.gnu.org,  Robert Burks
>   <rburksdev@gmail.com>
> Date: Fri, 23 Feb 2024 10:40:41 -0500
> 
> João Távora <joaotavora@gmail.com> writes:
> >> João, could you please review the patch?
> >
> > No, but I'm copying Spencer Baugh, who has expressed interest in becoming
> > Flymake maintainer (and has my full endorsement, though I haven't worked
> > out the bureaucracy, if there is any)
> >
> > João
> 
> The patch seems correct, if someone with commit access could please
> apply it.

Thanks, installed, and closing the bug.