bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[xhcoding]

When the cursor is at the position of the following code,
pressing tab cannot indent to the correct position.

int add() {
|  <-- pressing tab can not indent
}

The expected position after pressing the tab:

int add() {
  |
}



In GNU Emacs 30.0.50 (build 6, x86_64-w64-mingw32)
Repository revision: 6fb8a4dff7ef22f96ebe1a775240617aabac6526
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.22621
System Description: Microsoft Windows 10 Home China (v10.0.2009.22621.1105)

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[Eli Zaretskii]

> Date: Mon, 06 Mar 2023 11:03:51 +0800
> From: xhcoding <xhcoding@foxmail.com>
> 
> 
> When the cursor is at the position of the following code,
> pressing tab cannot indent to the correct position.
> 
> int add() {
> |  <-- pressing tab can not indent
> }
> 
> The expected position after pressing the tab:
> 
> int add() {
>   |
> }

I think you are supposed to switch the indentation style to bsd, and
then it will work.  The default is gnu.

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[Dmitry Gutov]

On 06/03/2023 14:57, Eli Zaretskii wrote:
>> Date: Mon, 06 Mar 2023 11:03:51 +0800
>> From: xhcoding<xhcoding@foxmail.com>
>>
>>
>> When the cursor is at the position of the following code,
>> pressing tab cannot indent to the correct position.
>>
>> int add() {
>> |  <-- pressing tab can not indent
>> }
>>
>> The expected position after pressing the tab:
>>
>> int add() {
>>    |
>> }
> I think you are supposed to switch the indentation style to bsd, and
> then it will work.  The default is gnu.

Using the gnu style, most of the expressions that the user will type 
will indent with OFFET number of characters, right?

Then it makes sense to indent the open line like that, too.

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[xhcoding]

On Tue, 07 Mar 2023 04:57:09 +0800,
Eli Zaretskii wrote:
> 
> > Date: Mon, 06 Mar 2023 11:03:51 +0800
> > From: xhcoding <xhcoding@foxmail.com>
> > 
> > 
> > When the cursor is at the position of the following code,
> > pressing tab cannot indent to the correct position.
> > 
> > int add() {
> > |  <-- pressing tab can not indent
> > }
> > 
> > The expected position after pressing the tab:
> > 
> > int add() {
> >   |
> > }
> 
> I think you are supposed to switch the indentation style to bsd, and
> then it will work.  The default is gnu.

Thank you very much, the bsd style is what I want.

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[Yuan Fu]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 06/03/2023 14:57, Eli Zaretskii wrote:
>>> Date: Mon, 06 Mar 2023 11:03:51 +0800
>>> From: xhcoding<xhcoding@foxmail.com>
>>>
>>>
>>> When the cursor is at the position of the following code,
>>> pressing tab cannot indent to the correct position.
>>>
>>> int add() {
>>> |  <-- pressing tab can not indent
>>> }
>>>
>>> The expected position after pressing the tab:
>>>
>>> int add() {
>>>    |
>>> }
>> I think you are supposed to switch the indentation style to bsd, and
>> then it will work.  The default is gnu.
>
> Using the gnu style, most of the expressions that the user will type
> will indent with OFFET number of characters, right?
>
> Then it makes sense to indent the open line like that, too.

Right. I fixed this regression on emacs-29.

Yuan

bug#61997: 30.0.50; c++-ts-mode; cannot indent in an empty function body

[Stefan Kangas]

Yuan Fu <casouri@gmail.com> writes:

> Right. I fixed this regression on emacs-29.

It seems like this issue was fixed, but it was left open in the bug
tracker.  I'm therefore closing it now.

Please remember to close bug reports when they are fixed.