From: Stefan Kangas <stefankangas@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 51368-done@debbugs.gnu.org,
Philipp Stephani <p.stephani2@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use
Date: Sun, 3 Sep 2023 01:48:07 -0700 [thread overview]
Message-ID: <CADwFkmmzk6O_CojB0cPSQk=mJ5+HWe3g_43-gZwCVwJNyzK38w@mail.gmail.com> (raw)
In-Reply-To: <87o7vjxpwl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 17:19:54 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> BTW, there's a third issue which is that
>>
>> (cl-case EXP
>> ((a b) FOO)
>> ((a c) BAR))
>>
>> won't warn about the duplicate `a`.
>>
>> After fixing this, many/most uses of `quote` will already emit
>> a warning, so maybe it would make the quote/function part of your second
>> patch unnecessary.
>
> I think it's nice to have an explicit error case for the quote case so
> that the warning can be better, though, so I've pushed Philipps patches
> to Emacs 29.
>
> But this test case should also emit a warning. Philipp, you don't
> happen to have a fix for that one, too? 😀
If I'm reading this right, it seems like the patches here were pushed to
master, but the bug was left open. I'm therefore closing this bug report.
If this conclusion is incorrect, please reply to this email (use "Reply
to all" in your email client) and we can reopen the bug report.
next prev parent reply other threads:[~2023-09-03 8:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 7:52 bug#51368: 29.0.50; `cl-case' should error on incorrect use Philipp Stephani
2021-10-24 8:16 ` Andreas Schwab
2021-10-24 12:46 ` Stefan Kangas
2021-10-24 17:48 ` Lars Ingebrigtsen
2021-10-31 18:53 ` Philipp Stephani
2021-11-01 13:31 ` Lars Ingebrigtsen
2021-11-12 19:34 ` Philipp Stephani
2021-11-14 1:09 ` Lars Ingebrigtsen
2021-11-14 15:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-13 15:19 ` Lars Ingebrigtsen
2022-09-13 16:12 ` Lars Ingebrigtsen
2022-09-13 16:15 ` Lars Ingebrigtsen
2023-09-03 8:48 ` Stefan Kangas [this message]
2022-10-02 21:39 ` Göktuğ Kayaalp
2023-09-03 13:40 ` Mattias Engdegård
2023-10-01 17:03 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmzk6O_CojB0cPSQk=mJ5+HWe3g_43-gZwCVwJNyzK38w@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=51368-done@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.