From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Date: Sun, 3 Sep 2023 01:48:07 -0700 Message-ID: References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> <87o7vjxpwl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2199"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51368-done@debbugs.gnu.org, Philipp Stephani , Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 10:49:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcin8-0000MV-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 10:49:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcimr-0000T8-86; Sun, 03 Sep 2023 04:48:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcimq-0000Rx-BL for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 04:48:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcimq-00089b-2s for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 04:48:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcin0-0000U1-9H for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 04:49:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Mail-Followup-To: 51368@debbugs.gnu.org, stefankangas@gmail.com, p.stephani2@gmail.com Original-Received: via spool by 51368-done@debbugs.gnu.org id=D51368.16937309091697 (code D ref 51368); Sun, 03 Sep 2023 08:49:02 +0000 Original-Received: (at 51368-done) by debbugs.gnu.org; 3 Sep 2023 08:48:29 +0000 Original-Received: from localhost ([127.0.0.1]:39298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcimT-0000RH-5k for submit@debbugs.gnu.org; Sun, 03 Sep 2023 04:48:29 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:55747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcimN-0000Q4-Tw for 51368-done@debbugs.gnu.org; Sun, 03 Sep 2023 04:48:27 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bcb89b4767so6095381fa.3 for <51368-done@debbugs.gnu.org>; Sun, 03 Sep 2023 01:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693730887; x=1694335687; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=SmXA1uI9YXG+LUWSzIIt7tzU2sPS0oihoOLNBwG5YMA=; b=LZ5PjRYjXIG+dpXL8XZxClL50qQRNjzjIW4tV4ZUzehm4CYNk0wHj6m286Ta9ft9i3 +pbunWenlxCDHXmkBTczFaxu2WBvxBK2NLp14AfAY/BFYqhpb/o82P+DlnfjVxVIQ8RI Z28E6yMdFAhVADEgHcWHjd4+znzOudg8OUIbqEdb078TZB8n32fvfFMgeH0+ZbyyOYNs zKAZ/RAUetTC8xXZbArBwcNj0aRyvz7Jx267lR+9WGUYYV19OXG2W8Xla5fCXoHfn8PD H7fgiIkm9oKyimxcC5KtbeIR7MUn4Gw4AmTp3TGmYyvZmXqmcYeo5xK9GxBozrJvCzlL 6QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693730887; x=1694335687; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SmXA1uI9YXG+LUWSzIIt7tzU2sPS0oihoOLNBwG5YMA=; b=e5lOumsAa/hPcukxBtCD4WzSWJiFaFdducB2+cSxZx69ZuihR9knIb56Rr5eJxdZFz ZsUqyfpvYbpZThwHQJA5bzINgAukxSEv+4vIntnp0ACfpitKY57abRIiL9cvgL9qz7Bv 0f5huhY6Pes5CyWH/dcFQW6P8gBtGjy72L+c+NsbKUW4UtItlZ16m0DIGHKVilsKh0A7 QHSHLTg2P5XkAS6YIGTlgIGRgbu6md/C9/qv50JYkg2cdU3boSITL5C/2M4fRRA7vZdA 1Yxx+S5elqd+tfKHXXXyu2LoCQP4DREyOfjYUXVjopCVPGfqlYae0DxO4unlhGuMHohA UJlg== X-Gm-Message-State: AOJu0YyR8ZDImjUMDYwCjRsqPeRHH7OmMac4WBaO3thRB2qi3DDvQB6G 7iOZHk7iOY+sSWmVmZ2Fm6Vo0DtrWqp4AoBoVJklLR5mHsM= X-Google-Smtp-Source: AGHT+IGtqbeE/PHHF5TgzJ9rfQveXIXUJGJzyjW3rx/bUj474tT3oAkAieRo+IpOr9G//URNYLMNXB6ILicZepFPyf4= X-Received: by 2002:a05:6512:3c9f:b0:4ff:7046:984a with SMTP id h31-20020a0565123c9f00b004ff7046984amr5520773lfv.7.1693730887498; Sun, 03 Sep 2023 01:48:07 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 01:48:07 -0700 In-Reply-To: <87o7vjxpwl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Sep 2022 17:19:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269092 Archived-At: Lars Ingebrigtsen writes: > Stefan Monnier writes: > >> BTW, there's a third issue which is that >> >> (cl-case EXP >> ((a b) FOO) >> ((a c) BAR)) >> >> won't warn about the duplicate `a`. >> >> After fixing this, many/most uses of `quote` will already emit >> a warning, so maybe it would make the quote/function part of your second >> patch unnecessary. > > I think it's nice to have an explicit error case for the quote case so > that the warning can be better, though, so I've pushed Philipps patches > to Emacs 29. > > But this test case should also emit a warning. Philipp, you don't > happen to have a fix for that one, too? =F0=9F=98=80 If I'm reading this right, it seems like the patches here were pushed to master, but the bug was left open. I'm therefore closing this bug report. If this conclusion is incorrect, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report.