all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59920-done@debbugs.gnu.org
Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding
Date: Fri, 1 Sep 2023 22:07:50 +0200	[thread overview]
Message-ID: <CADwFkmmJviRWg0ZaoPy33LAkK81XL++T6ufdGGGiYPV42voc+Q@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=JuxYHHNAApbWT0KMQsm4KCwk=qEnOHh-5=kAH+iUMWw@mail.gmail.com>

Version: 30.1

Stefan Kangas <stefankangas@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> +(defcustom checkdoc-lexical-binding-flag t
> >> +  "Non-nil means generate warnings if file is not using lexical binding.
> >> +See Info node `(elisp) Converting to Lexical Binding' for more."
> >> +  :type 'boolean
> >> +  :version "29.1")
> >
> > Should be "30.1", I guess?
>
> Yes, well spotted.
>
> >> +                 (checkdoc-create-error
> >> +                  "The first line should end with \"-*- lexical-binding: t -*-\""
> >
> > Is this accurate?  IOW, does the lexical-binding cookie have to be the
> > last on the first line?
>
> You're right, it's not accurate.  I changed it to say:
>
>     The first line should contain "-*- lexical-binding: t -*-"
>
> > Otherwise, LGTM, thanks.
>
> Thanks.

Pushed to master as commit 7d60d1652fc.





      reply	other threads:[~2023-09-01 20:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 10:10 bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Stefan Kangas
2022-12-09 12:25 ` Eli Zaretskii
2022-12-09 12:42   ` Stefan Kangas
2022-12-09 14:52     ` Eli Zaretskii
2022-12-10 23:26       ` Stefan Kangas
2022-12-11  7:29         ` Eli Zaretskii
2022-12-12  2:21           ` Stefan Kangas
2023-09-01 20:07             ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmJviRWg0ZaoPy33LAkK81XL++T6ufdGGGiYPV42voc+Q@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=59920-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.