From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Fri, 1 Sep 2023 22:07:50 +0200 Message-ID: References: <83v8mkzrvj.fsf@gnu.org> <83o7sczl1x.fsf@gnu.org> <83k02yv1n7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28939"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 22:09:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcASC-0007Jz-9F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 22:09:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcARq-0004nH-GJ; Fri, 01 Sep 2023 16:08:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcARp-0004ms-Kb for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 16:08:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcARp-0003CM-1s for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 16:08:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcARy-0007R5-BK for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 16:09:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59920@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 59920-done@debbugs.gnu.org id=D59920.169359890028525 (code D ref 59920); Fri, 01 Sep 2023 20:09:02 +0000 Original-Received: (at 59920-done) by debbugs.gnu.org; 1 Sep 2023 20:08:20 +0000 Original-Received: from localhost ([127.0.0.1]:34093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcARI-0007Q1-9S for submit@debbugs.gnu.org; Fri, 01 Sep 2023 16:08:20 -0400 Original-Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:54772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcARG-0007Po-3m for 59920-done@debbugs.gnu.org; Fri, 01 Sep 2023 16:08:18 -0400 Original-Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50078e52537so4318677e87.1 for <59920-done@debbugs.gnu.org>; Fri, 01 Sep 2023 13:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693598883; x=1694203683; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GyyNohzcRdOFzTijSV1qIajdpph27J77p+b1HwLs88M=; b=Y7j9GLSjuOA2+2j+wuHqQVuLtKOywM9YVfJdGjSAEYY5w+tuqqZSM6gakXlYzSC4oV tcTc+LdUeKnK7gUhCo48kWgjzsKLhxDQjqFAHFwVB4gSQl8sT8MWRdLqEoc3X24P25JO 4uosNelEKI1cncr3bv3SNcjDScmgLzjJVicNib4S8pVzl/mXDXDoGITY33ZqpjtPnLYu j6nLgLQHmTM5npcTdFfZ0DSafrKwRWGdzH3qION6Yitkia08PVZmtr2+9ntr2Ue+GaqO V9WmYsKzxr+iNKjKa6JhMpk+Eg2gDz+y3n/gg8BkeESfd0x5ePEbm9GTqnBaWjDIQEfB QFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693598883; x=1694203683; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GyyNohzcRdOFzTijSV1qIajdpph27J77p+b1HwLs88M=; b=JVf04KotQ+aUJwmNzPRjujuYUApb0w8+Sahnipq8ZN5gS6h+60FXTr8N6PqFL3yCZr juALtQEQ62jXbyZYLH4L2z0nehMKXZgj6gY3LeElR7YQ2JXVvcwavPD8uuZ1k9AfvANZ zh14+bUfYn/+dXUoKsxWWlf2iFnu/Moev4J2EIYgKWCzx+wm9uonkR+Cyy8Cd5c3JFfe poEKNfM2x6/hYYtoojCj0nNsLbEUmERYFYp8dy4FFQCoheSdCC/8HJa1Dx5Ta7dBoiux EC6lCYcS5theA2cYmmSiZ9/mpnqG9bJtFGkkRiYcRK5xvrCinods0WadV6eQZcvlWrgh ew9w== X-Gm-Message-State: AOJu0YwxbAJcoiExxtmGMd7vcPH/44Njx93yh17rHZTwOxmMzuzrU8pK pPvJJzakA92pti1uP0JeBjVf0WTZu5YDLhYvLvc= X-Google-Smtp-Source: AGHT+IHthozIScXExDv9SEACQbQ9JpwX5cuzJlO9r7KJ43eqjT7zrmdbg6IV3BzO7X17ohYiwO5uYlPVDq5hjp7VEZc= X-Received: by 2002:a19:8c59:0:b0:500:c180:59ca with SMTP id i25-20020a198c59000000b00500c18059camr2516083lfj.41.1693598882509; Fri, 01 Sep 2023 13:08:02 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268918 Archived-At: Version: 30.1 Stefan Kangas writes: > Eli Zaretskii writes: > > >> +(defcustom checkdoc-lexical-binding-flag t > >> + "Non-nil means generate warnings if file is not using lexical binding. > >> +See Info node `(elisp) Converting to Lexical Binding' for more." > >> + :type 'boolean > >> + :version "29.1") > > > > Should be "30.1", I guess? > > Yes, well spotted. > > >> + (checkdoc-create-error > >> + "The first line should end with \"-*- lexical-binding: t -*-\"" > > > > Is this accurate? IOW, does the lexical-binding cookie have to be the > > last on the first line? > > You're right, it's not accurate. I changed it to say: > > The first line should contain "-*- lexical-binding: t -*-" > > > Otherwise, LGTM, thanks. > > Thanks. Pushed to master as commit 7d60d1652fc.