all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
	59458-done@debbugs.gnu.org, "Lars Ingebrigtsen" <larsi@gnus.org>,
	"Łukasz Stelmach" <stlman@poczta.fm>
Subject: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Mon, 11 Sep 2023 17:32:20 -0700	[thread overview]
Message-ID: <CADwFkmkd-YYZi+haPN0PEWVdCZXpvfV7YJyQVxtKK9Lv_9LPbA@mail.gmail.com> (raw)
In-Reply-To: <871qf4ntjf.fsf@ericabrahamsen.net>

Version: 30.1

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> On 09/07/23 14:07 PM, Stefan Kangas wrote:
>
>> Eric,
>>
>> It would be great if you could help review this.  Thanks in advance.
>
> I've taken a closer look, and I do think this is okay. The `when' after
> the `dolist' only fires if the rule matches, the `if' is only there to
> see if this article has been previously scored or not. So moving the
> "(when trace" up to the top-level of the containing `when' (ie, out of the
> `if') does look like the right thing to do.

Thanks.  Installed it on master as commit e25ad6e2a30.





      reply	other threads:[~2023-09-12  0:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 21:30 bug#59458: [PATCH] Fix tracing for advanced scoring Łukasz Stelmach
2022-11-24  9:24 ` Eli Zaretskii
2022-11-24 19:39   ` Eric Abrahamsen
2023-09-07 21:07     ` Stefan Kangas
2023-09-08  6:04       ` Eli Zaretskii
2023-09-12  0:07       ` Eric Abrahamsen
2023-09-12  0:32         ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkd-YYZi+haPN0PEWVdCZXpvfV7YJyQVxtKK9Lv_9LPbA@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=59458-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=larsi@gnus.org \
    --cc=stlman@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.