From: Eli Zaretskii <eliz@gnu.org>
To: "Łukasz Stelmach" <stlman@poczta.fm>,
"Lars Ingebrigtsen" <larsi@gnus.org>,
"Eric Abrahamsen" <eric@ericabrahamsen.net>
Cc: 59458@debbugs.gnu.org
Subject: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Thu, 24 Nov 2022 11:24:44 +0200 [thread overview]
Message-ID: <831qpsyaar.fsf@gnu.org> (raw)
In-Reply-To: <20221121213055.2387178-1-stlman@poczta.fm> (message from Łukasz Stelmach on Mon, 21 Nov 2022 22:30:55 +0100)
> Cc: Łukasz Stelmach <stlman@poczta.fm>
> From: Łukasz Stelmach <stlman@poczta.fm>
> Date: Mon, 21 Nov 2022 22:30:55 +0100
>
> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing
> code outside of if so it's executed for both branches.
> ---
> lisp/gnus/gnus-logic.el | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el
> index c1b559ba6f4..346d8a28910 100644
> --- a/lisp/gnus/gnus-logic.el
> +++ b/lisp/gnus/gnus-logic.el
> @@ -71,11 +71,11 @@
> (+ (cdr score) new-score))
> (push (cons (mail-header-number gnus-advanced-headers)
> new-score)
> - gnus-newsgroup-scored)
> - (when trace
> - (push (cons "A file" rule)
> - ;; Must be synced with `gnus-score-edit-file-at-point'.
> - gnus-score-trace)))))))
> + gnus-newsgroup-scored))
> + (when trace
> + (push (cons "A file" rule)
> + ;; Must be synced with `gnus-score-edit-file-at-point'.
> + gnus-score-trace))))))
>
> (defun gnus-advanced-score-rule (rule)
> "Apply RULE to `gnus-advanced-headers'."
> --
> 2.30.2
Lars, Eric,
Any comments? Is this good to go in?
Thanks.
next prev parent reply other threads:[~2022-11-24 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 21:30 bug#59458: [PATCH] Fix tracing for advanced scoring Łukasz Stelmach
2022-11-24 9:24 ` Eli Zaretskii [this message]
2022-11-24 19:39 ` Eric Abrahamsen
2023-09-07 21:07 ` Stefan Kangas
2023-09-08 6:04 ` Eli Zaretskii
2023-09-12 0:07 ` Eric Abrahamsen
2023-09-12 0:32 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qpsyaar.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59458@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=larsi@gnus.org \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.