* Re: master 97679d06e8 1/2: Avoid an unnecessary call to intern
[not found] ` <20220919093912.CB62CC0270B@vcs2.savannah.gnu.org>
@ 2022-09-19 10:22 ` Po Lu
2022-09-19 13:23 ` Stefan Kangas
0 siblings, 1 reply; 2+ messages in thread
From: Po Lu @ 2022-09-19 10:22 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
Stefan Kangas <stefankangas@gmail.com> writes:
> branch: master
> commit 97679d06e854da4656b64df1bafa9a321c05349d
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
> Avoid an unnecessary call to intern
>
> * src/doc.c (Fdocumentation): Prefer DEFSYM to using intern directly.
Maybe we should get rid of all of the calls to intern with a static
string in one go?
I think leaving them there is really just a waste of cycles.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 97679d06e8 1/2: Avoid an unnecessary call to intern
2022-09-19 10:22 ` master 97679d06e8 1/2: Avoid an unnecessary call to intern Po Lu
@ 2022-09-19 13:23 ` Stefan Kangas
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2022-09-19 13:23 UTC (permalink / raw)
To: Po Lu, emacs-devel
Po Lu <luangruo@yahoo.com> writes:
>> * src/doc.c (Fdocumentation): Prefer DEFSYM to using intern directly.
>
> Maybe we should get rid of all of the calls to intern with a static
> string in one go?
Sounds good to me.
> I think leaving them there is really just a waste of cycles.
Getting rid of them also gives us compile-time error checking, which is
nice.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-19 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166358035244.5217.7919161622861356432@vcs2.savannah.gnu.org>
[not found] ` <20220919093912.CB62CC0270B@vcs2.savannah.gnu.org>
2022-09-19 10:22 ` master 97679d06e8 1/2: Avoid an unnecessary call to intern Po Lu
2022-09-19 13:23 ` Stefan Kangas
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.