all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
@ 2023-09-04 17:09 john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-09-04 19:16 ` Stefan Kangas
  2024-01-10 21:42 ` Stefan Kangas
  0 siblings, 2 replies; 4+ messages in thread
From: john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-09-04 17:09 UTC (permalink / raw)
  To: 65739

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Tags: patch

While looking at the java-ts-modes tests I noticed Ruby was missing from
the build-module script.



In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-08-29 built on localhost
Repository revision: fb9312722f7b0166f178b601811213a576be5ae4
Repository branch: main
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation=aot --with-pgtk
 --prefix=/home/jm/.opt'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-Ruby-to-the-tree-sitter-build-module-script.patch --]
[-- Type: text/patch, Size: 746 bytes --]

From cb73036bb916bef5fd5b862b935d8d564d7f6771 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Mon, 4 Sep 2023 12:08:34 -0500
Subject: [PATCH] Add Ruby to the tree-sitter build-module script

* admin/notes/tree-sitter/build-module/batch.sh (languages): Add
Ruby.
---
 admin/notes/tree-sitter/build-module/batch.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/admin/notes/tree-sitter/build-module/batch.sh b/admin/notes/tree-sitter/build-module/batch.sh
index 1d4076564dc..ec7231dd82f 100755
--- a/admin/notes/tree-sitter/build-module/batch.sh
+++ b/admin/notes/tree-sitter/build-module/batch.sh
@@ -16,6 +16,7 @@ languages=
     'javascript'
     'json'
     'python'
+    'ruby'
     'rust'
     'toml'
     'tsx'
-- 
2.41.0


[-- Attachment #3.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #3.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 503 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
  2023-09-04 17:09 bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-09-04 19:16 ` Stefan Kangas
  2023-09-05  1:07   ` Dmitry Gutov
  2024-01-10 21:42 ` Stefan Kangas
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2023-09-04 19:16 UTC (permalink / raw)
  To: john muhl, 65739; +Cc: Perry Smith, Yuan Fu

john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:

> Tags: patch
>
> While looking at the java-ts-modes tests I noticed Ruby was missing from
> the build-module script.

Yuan and Perry, any comments here?

> In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
>  3.24.38, cairo version 1.17.8) of 2023-08-29 built on localhost
> Repository revision: fb9312722f7b0166f178b601811213a576be5ae4
> Repository branch: main
> System Description: Fedora Linux 38 (Workstation Edition)
>
> Configured using:
>  'configure --with-native-compilation=aot --with-pgtk
>  --prefix=/home/jm/.opt'
>
> From cb73036bb916bef5fd5b862b935d8d564d7f6771 Mon Sep 17 00:00:00 2001
> From: john muhl <jm@pub.pink>
> Date: Mon, 4 Sep 2023 12:08:34 -0500
> Subject: [PATCH] Add Ruby to the tree-sitter build-module script
>
> * admin/notes/tree-sitter/build-module/batch.sh (languages): Add
> Ruby.
> ---
>  admin/notes/tree-sitter/build-module/batch.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/batch.sh b/admin/notes/tree-sitter/build-module/batch.sh
> index 1d4076564dc..ec7231dd82f 100755
> --- a/admin/notes/tree-sitter/build-module/batch.sh
> +++ b/admin/notes/tree-sitter/build-module/batch.sh
> @@ -16,6 +16,7 @@ languages=
>      'javascript'
>      'json'
>      'python'
> +    'ruby'
>      'rust'
>      'toml'
>      'tsx'
> --
> 2.41.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
  2023-09-04 19:16 ` Stefan Kangas
@ 2023-09-05  1:07   ` Dmitry Gutov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2023-09-05  1:07 UTC (permalink / raw)
  To: Stefan Kangas, john muhl, 65739; +Cc: Perry Smith, Yuan Fu

On 04/09/2023 22:16, Stefan Kangas wrote:
> john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors"<bug-gnu-emacs@gnu.org>  writes:
> 
>> Tags: patch
>>
>> While looking at the java-ts-modes tests I noticed Ruby was missing from
>> the build-module script.
> Yuan and Perry, any comments here?

Am neither, but this looks "obviously correct" to me without testing 
(the ruby grammar doesn't need any special settings to compile).






^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script
  2023-09-04 17:09 bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-09-04 19:16 ` Stefan Kangas
@ 2024-01-10 21:42 ` Stefan Kangas
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2024-01-10 21:42 UTC (permalink / raw)
  To: john muhl; +Cc: 65739-done

Version: 30.1

john muhl <jm@pub.pink> writes:

> Tags: patch
>
> While looking at the java-ts-modes tests I noticed Ruby was missing from
> the build-module script.

Thanks, installed on master (a0133f63450) and closing.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-10 21:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-04 17:09 bug#65739: [PATCH] Add Ruby to the tree-sitter build-module script john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 19:16 ` Stefan Kangas
2023-09-05  1:07   ` Dmitry Gutov
2024-01-10 21:42 ` Stefan Kangas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.