all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Manphiz <manphiz@gmail.com>
Cc: 65882-done@debbugs.gnu.org,
	Philip Kaludercic <philipk@posteo.net>,
	Ryan Yeske <rcyeske@gmail.com>, Leo Liu <sdl.web@gmail.com>
Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting
Date: Sat, 23 Sep 2023 04:41:08 -0700	[thread overview]
Message-ID: <CADwFkm=WvZaAbP4JRyPXhSmAG1ytBcfe0-Us1rjBuf_o2NubPg@mail.gmail.com> (raw)
In-Reply-To: <87fs3528l2.fsf@debian-hx90.lan>

Manphiz <manphiz@gmail.com> writes:

>> I don't necessarily object, but is it a regression?
>
> The reconnecting and rejoining channels feature is broken in certain
> situation, and this patch fixes that.  Some other users claimed this
> works for them, so I would say this may be considered a regression.
>
>> Is the change safe?
>
> According to the logic of the code, this patch enables doing work that
> (I believe) should have been done and not changing anything else, so I
> would say it is safe.
>
>> If the answer to either of those questions is "no", I think master is
>> the safer choice.
>
> I would say the answers are both yes, but of course that's just my
> opinion and the decision is up to you :)

Thanks.  If Philip agrees, I see no reason why this can't be installed
on emacs-29.





  reply	other threads:[~2023-09-23 11:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  0:58 bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Manphiz
2023-09-14 22:57 ` Manphiz
2023-09-15  2:27   ` Stefan Kangas
2023-09-15  5:30     ` Manphiz
2023-09-15  7:50       ` Philip Kaludercic
2023-09-15  8:15         ` Manphiz
2023-09-21 15:00         ` Manphiz
2023-09-21 16:27           ` Philip Kaludercic
2023-09-21 16:57             ` Manphiz
2023-09-22  8:23               ` Philip Kaludercic
2023-09-22  8:46                 ` Stefan Kangas
2023-09-22 21:37                   ` Manphiz
2023-09-23 11:41                     ` Stefan Kangas [this message]
2023-09-23 12:43                       ` Philip Kaludercic
2023-09-23 22:34                         ` Manphiz
2023-09-14 22:57 ` Manphiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=WvZaAbP4JRyPXhSmAG1ytBcfe0-Us1rjBuf_o2NubPg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=65882-done@debbugs.gnu.org \
    --cc=manphiz@gmail.com \
    --cc=philipk@posteo.net \
    --cc=rcyeske@gmail.com \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.