From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Sat, 23 Sep 2023 04:41:08 -0700 Message-ID: References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> <875y4331m2.fsf@debian-hx90.lan> <87cyyavcoh.fsf@posteo.net> <87fs3528l2.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65882-done@debbugs.gnu.org, Philip Kaludercic , Ryan Yeske , Leo Liu To: Manphiz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 13:42:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qk11Y-0006tK-N0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 13:42:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qk11G-0007i6-E2; Sat, 23 Sep 2023 07:41:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk11D-0007hD-5M for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 07:41:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qk11C-00019X-Sz for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 07:41:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qk11O-0002t2-12 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.169546928811041 (code D ref 65882); Sat, 23 Sep 2023 11:42:01 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 23 Sep 2023 11:41:28 +0000 Original-Received: from localhost ([127.0.0.1]:37888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk10q-0002s1-3H for submit@debbugs.gnu.org; Sat, 23 Sep 2023 07:41:28 -0400 Original-Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:59400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk10o-0002ro-3F for 65882-done@debbugs.gnu.org; Sat, 23 Sep 2023 07:41:26 -0400 Original-Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2bffc55af02so58042561fa.2 for <65882-done@debbugs.gnu.org>; Sat, 23 Sep 2023 04:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695469269; x=1696074069; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZW46XKfWuNJ49sjVrFztlqwJVB+pY7t26+2B84R9/DE=; b=adE+b+DTKOnxBx5sLACZdcvLQqOVKDkLraUT29D/Y67QxRfdctOPqZvleXeIqZM5su UbcMPdQPCg9b3nx8hoeHPhOyyyqzS1Ha4OrAO04oW8FBSWhsvQvp2gi7xgo5C+zi3+nV AJjSGh1NdFre8RrnBCaE0zDKdDrSaEMzj3hOKF9piZD+BrKfPTqYkToOkY2RCrRYIqiI nxyl+gRQ6btFxDfSIthilv+NMHn8pnxgat8xDZXa4lWAzRbU6coqkUhsCgZMngKmHhwt mQv9CqMf51PN0cs0vBaiZe2SSa9/c3MOQbLalmLYrHQT2QPgtR5HdDKj4pn1N1mzLYVJ HCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695469269; x=1696074069; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZW46XKfWuNJ49sjVrFztlqwJVB+pY7t26+2B84R9/DE=; b=B00qJxzszaEiCL/MXJjXlAl3WWW24eWk7q6BkAmRuSg0ZZv1dcdY/tIxj4CbTWDjdb 7XOK6GkWkUA8cPDUDwF4GDs+vTsptyxmDgSCh2zJ+y4PT6rGZ7U+4t3eOAHZMhu5522S 2C6R7FpelLcCMkt4vPAe5P44OIfSHXBS20rWs+zzJaL6xOYjdr57FOoXiLrdE+3lMgn6 RMeOMxYcvx7UDFDX9WsXoNhqtZvO04GWQAnqhaQTVdoNDm9oPWWbE1mvm+GbdIDK3Kh+ aw2XN1Mtn72zZ9jj7nArrNPSuJTtwd1hzlCarndCYkzj8iCBlqHRWGPRa5FAlc9j2dCy hTVQ== X-Gm-Message-State: AOJu0YzbfDx5/bLQBk6IfiLV25F4M96wKY7ydYRDzF2gLtdHJMi8XQ0y lvhEOD7xJ4iZUz+8FCXfFn0BrX2moQDYnDaskpM= X-Google-Smtp-Source: AGHT+IHtH2g/6EguPdv/2DYYwjWGROMyYM51Q2QT6Xfy1Dni9hbP+u0NSdSwfNt0ct4eA5we47M7wGDxZ4lX8lqv/B0= X-Received: by 2002:a2e:7309:0:b0:2bc:c1d9:6848 with SMTP id o9-20020a2e7309000000b002bcc1d96848mr1366347ljc.44.1695469268668; Sat, 23 Sep 2023 04:41:08 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 23 Sep 2023 04:41:08 -0700 In-Reply-To: <87fs3528l2.fsf@debian-hx90.lan> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271159 Archived-At: Manphiz writes: >> I don't necessarily object, but is it a regression? > > The reconnecting and rejoining channels feature is broken in certain > situation, and this patch fixes that. Some other users claimed this > works for them, so I would say this may be considered a regression. > >> Is the change safe? > > According to the logic of the code, this patch enables doing work that > (I believe) should have been done and not changing anything else, so I > would say it is safe. > >> If the answer to either of those questions is "no", I think master is >> the safer choice. > > I would say the answers are both yes, but of course that's just my > opinion and the decision is up to you :) Thanks. If Philip agrees, I see no reason why this can't be installed on emacs-29.