From: Dominique Quatravaux <dominique@quatravaux.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 68954@debbugs.gnu.org
Subject: bug#68954: Offending commit
Date: Thu, 8 Feb 2024 10:36:05 +0100 [thread overview]
Message-ID: <CA+tDuRz7J17cDubOsGN9m4DzP5egt-=3ofCxcRseb1ZmVJVVrQ@mail.gmail.com> (raw)
In-Reply-To: <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 385 bytes --]
Le jeu. 8 févr. 2024 à 02:35, Yuan Fu <casouri@gmail.com> a écrit :
>
>
> Actually, here’s what I would write for your change, feel free to modify
> it as you like.
>
>
Many thanks for the step-by-step instructions! Attached is what `git
format-patch` gave me, I hope that I got everything right.
Yours truly,
--
Dominique Quatravaux
dominique@quatravaux.org
[-- Attachment #1.2: Type: text/html, Size: 868 bytes --]
[-- Attachment #2: 0001-Fix-treesit_traverse_get_predicate-bug-68954.patch --]
[-- Type: application/octet-stream, Size: 1305 bytes --]
From 0eb6c02b3f16b4567053b7476039b0fbf6a0f55a Mon Sep 17 00:00:00 2001
From: Dominique Quatravaux <dominique.quatravaux@epfl.ch>
Date: Thu, 8 Feb 2024 10:19:10 +0100
Subject: [PATCH] Fix treesit_traverse_get_predicate (bug#68954)
Commit d005e685e1df7692085378633348db39a5190374 should have replaced
assq_no_quit with assq_no_signal, but didn't, this commit fixes that.
* src/treesit.c (treesit_traverse_get_predicate): Replace assq_no_quit
with assq_no_signal.
Copyright-paperwork-exempt: yes
---
src/treesit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/treesit.c b/src/treesit.c
index 69b59fca111..aece3a7728e 100644
--- a/src/treesit.c
+++ b/src/treesit.c
@@ -3268,11 +3268,11 @@ treesit_traverse_child_helper (TSTreeCursor *cursor,
static Lisp_Object
treesit_traverse_get_predicate (Lisp_Object thing, Lisp_Object language)
{
- Lisp_Object cons = assq_no_quit (language, Vtreesit_thing_settings);
+ Lisp_Object cons = assq_no_signal (language, Vtreesit_thing_settings);
if (NILP (cons))
return Qnil;
Lisp_Object definitions = XCDR (cons);
- Lisp_Object entry = assq_no_quit (thing, definitions);
+ Lisp_Object entry = assq_no_signal (thing, definitions);
if (NILP (entry))
return Qnil;
/* ENTRY looks like (THING PRED). */
--
2.43.0
next prev parent reply other threads:[~2024-02-08 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:08 bug#68954: [PATCH] Crasher in treesit_traverse_get_predicate Dominique Quatravaux
2024-02-06 17:15 ` bug#68954: Offending commit Dominique Quatravaux
2024-02-07 1:58 ` Yuan Fu
2024-02-07 7:24 ` Dominique Quatravaux
2024-02-08 1:35 ` Yuan Fu
2024-02-08 9:36 ` Dominique Quatravaux [this message]
2024-02-09 5:27 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+tDuRz7J17cDubOsGN9m4DzP5egt-=3ofCxcRseb1ZmVJVVrQ@mail.gmail.com' \
--to=dominique@quatravaux.org \
--cc=68954@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.