From: Yuan Fu <casouri@gmail.com>
To: Dominique Quatravaux <dominique@quatravaux.org>
Cc: 68954@debbugs.gnu.org
Subject: bug#68954: Offending commit
Date: Wed, 7 Feb 2024 17:35:44 -0800 [thread overview]
Message-ID: <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> (raw)
In-Reply-To: <CA+tDuRwqUL0CSRY1tihwVuw7V27EjgJfj5WnzW08pVPPmK1BTQ@mail.gmail.com>
> On Feb 6, 2024, at 11:24 PM, Dominique Quatravaux <dominique@quatravaux.org> wrote:
>
> Le mer. 7 févr. 2024 à 02:58, Yuan Fu <casouri@gmail.com> a écrit :
>
>
> Thanks! If you want to submit a patch I’m more than happy to apply it for you
>
> I attached a patch to my first email already.
My bad, I wasn’t clear enough. I meant a patch generated by git format-patch, which includes a commit message, etc. This way when I apply it it’ll show your as the author. If you don’t care about it, I can apply the diff myself and push it.
Btw, there’s a specific format for commit messages, you can check out the CONTRIBUTE file under repo root, in the “Commit messages” section.
Actually, here’s what I would write for your change, feel free to modify it as you like.
Fix treesit_traverse_get_predicate (bug#68954)
Commit d005e685e1df7692085378633348db39a5190374 should have replaced
assq_no_quit with assq_no_signal, but didn't, this commit fixes that.
* src/treesit.c (treesit_traverse_get_predicate): Replace assq_no_quit
with assq_no_signal.
Yuan
next prev parent reply other threads:[~2024-02-08 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:08 bug#68954: [PATCH] Crasher in treesit_traverse_get_predicate Dominique Quatravaux
2024-02-06 17:15 ` bug#68954: Offending commit Dominique Quatravaux
2024-02-07 1:58 ` Yuan Fu
2024-02-07 7:24 ` Dominique Quatravaux
2024-02-08 1:35 ` Yuan Fu [this message]
2024-02-08 9:36 ` Dominique Quatravaux
2024-02-09 5:27 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com \
--to=casouri@gmail.com \
--cc=68954@debbugs.gnu.org \
--cc=dominique@quatravaux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.