Re: master 996b9576713 2/3: New function treesit-parser-changed-ranges

Re: master 996b9576713 2/3: New function treesit-parser-changed-ranges

[Michael Albinus]

Yuan Fu <casouri@gmail.com> writes:

Hi,

> diff --git a/etc/NEWS b/etc/NEWS
> index 8ad1e78ca60..73daac1be3b 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2538,6 +2538,9 @@ only return parsers for that language.  If TAG is given, only return
>  parsers with that tag.  Note that passing nil as tag doesn't mean return
>  all parsers, but rather "all parsers with no tags".
>
> ++++
> +*** New function 'treesit-parser-changed-ranges' which returns buffer regions that are affected by the last buffer edits
> +
>  \f
>  * Changes in Emacs 30.1 on Non-Free Operating Systems

Achhhh. You still don't respect the line length limit. Please adjust.

Furthermore, the first line of a NEWS entry must be a sentence of its
own, with a trailing period.

Best regards, Michael.

Re: master 996b9576713 2/3: New function treesit-parser-changed-ranges

[Yuan Fu]

> On Apr 20, 2024, at 12:19 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
> Hi,
> 
>> diff --git a/etc/NEWS b/etc/NEWS
>> index 8ad1e78ca60..73daac1be3b 100644
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -2538,6 +2538,9 @@ only return parsers for that language.  If TAG is given, only return
>> parsers with that tag.  Note that passing nil as tag doesn't mean return
>> all parsers, but rather "all parsers with no tags".
>> 
>> ++++
>> +*** New function 'treesit-parser-changed-ranges' which returns buffer regions that are affected by the last buffer edits
>> +
>> 
>> * Changes in Emacs 30.1 on Non-Free Operating Systems
> 
> Achhhh. You still don't respect the line length limit. Please adjust.
> 
> Furthermore, the first line of a NEWS entry must be a sentence of its
> own, with a trailing period.
> 
> Best regards, Michael.

Sorry about that :-( It should be fixed now. I just realized that you’re talking about the header line, which I always thought are not supposed to be wrapped. I’ll make sure to wrap header lines in the future.

Yuan

Re: master 996b9576713 2/3: New function treesit-parser-changed-ranges

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 20 Apr 2024 15:32:25 -0700
> Cc: emacs-devel@gnu.org
> 
> >> +*** New function 'treesit-parser-changed-ranges' which returns buffer regions that are affected by the last buffer edits
> >> +
> >> 
> >> * Changes in Emacs 30.1 on Non-Free Operating Systems
> > 
> > Achhhh. You still don't respect the line length limit. Please adjust.
> > 
> > Furthermore, the first line of a NEWS entry must be a sentence of its
> > own, with a trailing period.
> > 
> > Best regards, Michael.
> 
> Sorry about that :-( It should be fixed now.

Did you forget to push?

> I just realized that you’re talking about the header line, which I always thought are not supposed to be wrapped. I’ll make sure to wrap header lines in the future.

Header lines are indeed not supposed to be wrapped, but they need to
be shorter than 80 columns.  If you cannot say something in that few
characters, say just part of it and leave the rest to the body of the
entry.  For example, in the above case, I would do it like this:

  *** New function 'treesit-parser-changed-ranges'.
  It returns buffer regions that are affected by the last buffer
  edits[...]

Re: master 996b9576713 2/3: New function treesit-parser-changed-ranges

[Yuan Fu]

> On Apr 20, 2024, at 9:51 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 20 Apr 2024 15:32:25 -0700
>> Cc: emacs-devel@gnu.org
>> 
>>>> +*** New function 'treesit-parser-changed-ranges' which returns buffer regions that are affected by the last buffer edits
>>>> +
>>>> 
>>>> * Changes in Emacs 30.1 on Non-Free Operating Systems
>>> 
>>> Achhhh. You still don't respect the line length limit. Please adjust.
>>> 
>>> Furthermore, the first line of a NEWS entry must be a sentence of its
>>> own, with a trailing period.
>>> 
>>> Best regards, Michael.
>> 
>> Sorry about that :-( It should be fixed now.
> 
> Did you forget to push?

I forgot to push :-(

> 
>> I just realized that you’re talking about the header line, which I always thought are not supposed to be wrapped. I’ll make sure to wrap header lines in the future.
> 
> Header lines are indeed not supposed to be wrapped, but they need to
> be shorter than 80 columns.  If you cannot say something in that few
> characters, say just part of it and leave the rest to the body of the
> entry.  For example, in the above case, I would do it like this:
> 
>  *** New function 'treesit-parser-changed-ranges'.
>  It returns buffer regions that are affected by the last buffer
>  edits[…]

I see. It all makes now. Thanks :-)

Yuan